search

netobserv / flowlogs-pipeline

Transform flow logs into metrics
Apache License 2.0
75 stars 23 forks source link

Layer enrichment: remove hard-coded pieces, add tests #579

Closed jotak closed 7 months ago

jotak commented 8 months ago

No user-facing change.

(this PR requires to update the operator for configuring FLP)

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/flowlogs-pipeline/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 8 months ago

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (40b6948) 65.80% compared to head (cad6ded) 66.45%. Report is 9 commits behind head on main.

Files Patch % Lines
pkg/pipeline/transform/kubernetes/enrich.go 75.21% 24 Missing and 5 partials :warning:
...peline/transform/kubernetes/informers/informers.go 16.00% 21 Missing :warning:
...e/transform/kubernetes/informers/informers-mock.go 88.00% 3 Missing :warning:
pkg/pipeline/transform/transform_network.go 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #579 +/- ## ========================================== + Coverage 65.80% 66.45% +0.65% ========================================== Files 102 103 +1 Lines 7445 7506 +61 ========================================== + Hits 4899 4988 +89 + Misses 2256 2225 -31 - Partials 290 293 +3 ``` | [Flag](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/579/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `66.45% <67.64%> (+0.65%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jotak commented 8 months ago

/hold as @OlivierCazade started a similar work on his side

jotak commented 7 months ago

superseded by https://github.com/netobserv/flowlogs-pipeline/pull/580