netobserv / flowlogs-pipeline

Transform flow logs into metrics
Apache License 2.0
77 stars 24 forks source link

WIP NETOBSERV-1471 add tcp write stage #604

Closed jpinsonneau closed 8 months ago

jpinsonneau commented 9 months ago

Description

This PR adds TCP write stage to FLP. We need to decide if we move to gRPC instead before merging.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci[bot] commented 9 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/flowlogs-pipeline/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 9 months ago

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (831e2ad) 66.06% compared to head (7dec780) 65.77%. Report is 3 commits behind head on main.

Files Patch % Lines
pkg/pipeline/write/write_tcp.go 0.00% 30 Missing :warning:
pkg/config/pipeline_builder.go 0.00% 2 Missing :warning:
pkg/config/stage_params.go 0.00% 2 Missing :warning:
pkg/pipeline/pipeline_builder.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #604 +/- ## ========================================== - Coverage 66.06% 65.77% -0.29% ========================================== Files 103 104 +1 Lines 7509 7545 +36 ========================================== + Hits 4961 4963 +2 - Misses 2255 2290 +35 + Partials 293 292 -1 ``` | [Flag](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/604/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/604/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `65.77% <0.00%> (-0.29%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jpinsonneau commented 8 months ago

Closing this in favor of https://github.com/netobserv/flowlogs-pipeline/pull/621