netobserv / flowlogs-pipeline

Transform flow logs into metrics
Apache License 2.0
77 stars 24 forks source link

Enum replacement in API #614

Closed jotak closed 8 months ago

jotak commented 8 months ago

Fixes #608 All enums are moved to the new enum model

openshift-ci[bot] commented 8 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 83.82353% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 67.38%. Comparing base (b1ccc26) to head (10410f7).

Files Patch % Lines
pkg/pipeline/encode/encode_kafka.go 0.00% 5 Missing :warning:
pkg/pipeline/transform/transform_network.go 66.66% 5 Missing :warning:
...ipeline/encode/opentelemetry/encode_otlpmetrics.go 33.33% 4 Missing :warning:
pkg/pipeline/encode/encode_prom_metric.go 50.00% 3 Missing :warning:
pkg/pipeline/utils/sasl.go 0.00% 2 Missing :warning:
pkg/api/conntrack.go 90.90% 1 Missing :warning:
pkg/pipeline/decode/decode.go 50.00% 1 Missing :warning:
pkg/pipeline/ingest/ingest_stdin.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #614 +/- ## ========================================== - Coverage 67.44% 67.38% -0.06% ========================================== Files 110 102 -8 Lines 7633 7589 -44 ========================================== - Hits 5148 5114 -34 + Misses 2173 2163 -10 Partials 312 312 ``` | [Flag](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/614/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/614/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `67.38% <83.82%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 8 months ago

New image: quay.io/netobserv/flowlogs-pipeline:4f8630a

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4f8630a make set-flp-image
jotak commented 8 months ago

/approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/flowlogs-pipeline/blob/main/OWNERS)~~ [jotak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jotak commented 8 months ago

no big deal, but adding breaking change label due to this commit https://github.com/netobserv/flowlogs-pipeline/pull/614/commits/10410f7b8333c5fbaf8eeb09bb2fa3cfb2ca82fe - it was integrated in this PR by mistake, I was expecting to bring it later via #640