NETOBSERV-1471 add gRPC write stage

jpinsonneau commented 8 months ago

Description

This PR adds gRPC write stage to FLP. The alternative tcp PR is also available

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[x] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
[ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?
- [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
[ ] Does this PR require a product release notes entry?
- [ ] If so, fill in "Release Note Text" in the JIRA.
[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
- [ ] If so, make sure it is described in the JIRA ticket.
QE requirements (check 1 from the list):
- [ ] Standard QE validation, with pre-merge tests unless stated otherwise.
- [ ] Regression tests only (e.g. refactoring with no user-facing change).
- [x] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

openshift-ci[bot] commented 8 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 61.86047% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 67.07%. Comparing base (ab65bc4) to head (bc514f2). Report is 11 commits behind head on main.

Files	Patch %	Lines
...kg/pipeline/write/grpc/genericmap/genericmap.pb.go	52.08%	44 Missing and 2 partials :warning:
pkg/api/write_grpc.go	18.18%	6 Missing and 3 partials :warning:
pkg/pipeline/write/grpc/server.go	73.33%	6 Missing and 2 partials :warning:
...peline/write/grpc/genericmap/genericmap_grpc.pb.go	80.00%	5 Missing and 1 partial :warning:
pkg/pipeline/write/write_grpc.go	80.00%	4 Missing and 2 partials :warning:
pkg/pipeline/write/grpc/client.go	68.75%	4 Missing and 1 partial :warning:
pkg/pipeline/pipeline_builder.go	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #621 +/- ## ========================================== + Coverage 66.97% 67.07% +0.09% ========================================== Files 104 110 +6 Lines 7446 7674 +228 ========================================== + Hits 4987 5147 +160 - Misses 2162 2214 +52 - Partials 297 313 +16 ``` | [Flag](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/621/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `67.07% <61.86%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jotak commented 8 months ago

Thanks @jpinsonneau /lgtm

jpinsonneau commented 8 months ago

I'm merging this since only CLI will us it for now; no impact on existing features

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/flowlogs-pipeline/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

netobserv / flowlogs-pipeline