netobserv / flowlogs-pipeline

Transform flow logs into metrics
Apache License 2.0
75 stars 23 forks source link

NETOBSERV-1514: drop go1.20 support #629

Closed jotak closed 6 months ago

jotak commented 6 months ago

I had to upgrade the linter, and took that opportunity to enable more linters (same config as what we have on the agent) But that led to quite a lot of fixes, this is why the PR is pretty big; There's no (intentional) functional changes

openshift-ci-robot commented 6 months ago

@jotak: This pull request references NETOBSERV-1514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/flowlogs-pipeline/pull/629): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fflowlogs-pipeline). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 78.96679% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 67.05%. Comparing base (ddc1f67) to head (382fd38). Report is 2 commits behind head on main.

Files Patch % Lines
pkg/pipeline/extract/conntrack/store.go 76.66% 7 Missing :warning:
pkg/api/write_loki.go 16.66% 1 Missing and 4 partials :warning:
pkg/confgen/confgen.go 42.85% 3 Missing and 1 partial :warning:
pkg/pipeline/encode/metrics_common.go 80.95% 4 Missing :warning:
pkg/pipeline/utils/sasl.go 0.00% 4 Missing :warning:
pkg/pipeline/write/write_loki.go 0.00% 4 Missing :warning:
pkg/confgen/extract.go 50.00% 3 Missing :warning:
pkg/pipeline/transform/location/location.go 76.92% 3 Missing :warning:
pkg/test/utils.go 57.14% 3 Missing :warning:
cmd/confgenerator/main.go 50.00% 2 Missing :warning:
... and 15 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #629 +/- ## ========================================== + Coverage 67.02% 67.05% +0.03% ========================================== Files 110 110 Lines 7676 7677 +1 ========================================== + Hits 5145 5148 +3 Misses 2217 2217 + Partials 314 312 -2 ``` | [Flag](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/629/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/629/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `67.05% <78.96%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openshift-ci-robot commented 6 months ago

@jotak: This pull request references NETOBSERV-1514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/flowlogs-pipeline/pull/629): >I had to upgrade the linter, and took that opportunity to enable more linters (same config as what we have on the agent) >But that led to quite a lot of fixes, this is why the PR is pretty big; There's no (intentional) functional changes Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fflowlogs-pipeline). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
github-actions[bot] commented 6 months ago

New image: quay.io/netobserv/flowlogs-pipeline:d37829b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d37829b make set-flp-image
github-actions[bot] commented 6 months ago

New image: quay.io/netobserv/flowlogs-pipeline:c80abff

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=c80abff make set-flp-image
jotak commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/flowlogs-pipeline/blob/main/OWNERS)~~ [jotak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment