netobserv / flowlogs-pipeline

Transform flow logs into metrics
Apache License 2.0
77 stars 24 forks source link

[Minor] Add logs - give some workaround for prom registry issue #685

Closed jotak closed 4 months ago

jotak commented 4 months ago

Description

Related to https://issues.redhat.com/browse/NETOBSERV-1748 (but not fixing it) Add some logs, add provide some workaround when the issue comes up

More work needs to be done to restart a fresh new registry

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/flowlogs-pipeline/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 16.27907% with 36 lines in your changes missing coverage. Please review.

Project coverage is 65.12%. Comparing base (915552b) to head (2c7f28e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #685 +/- ## ======================================= Coverage 65.12% 65.12% ======================================= Files 107 107 Lines 6844 6844 ======================================= Hits 4457 4457 Misses 2070 2070 Partials 317 317 ``` | [Flag](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/685/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/685/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `65.12% <16.27%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/685?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [pkg/pipeline/utils/timed\_cache.go](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/685?src=pr&el=tree&filepath=pkg%2Fpipeline%2Futils%2Ftimed_cache.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL3BpcGVsaW5lL3V0aWxzL3RpbWVkX2NhY2hlLmdv) | `95.06% <100.00%> (ø)` | | | [pkg/pipeline/encode/encode\_prom.go](https://app.codecov.io/gh/netobserv/flowlogs-pipeline/pull/685?src=pr&el=tree&filepath=pkg%2Fpipeline%2Fencode%2Fencode_prom.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL3BpcGVsaW5lL2VuY29kZS9lbmNvZGVfcHJvbS5nbw==) | `40.79% <14.28%> (ø)` | |
jotak commented 4 months ago

superseded by https://github.com/netobserv/flowlogs-pipeline/pull/686