Closed jotak closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/hold
holding for perf tests
Patch coverage: 75.00%
and no project coverage change.
Comparison is base (
2eae149
) 39.51% compared to head (561ef60
) 39.51%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm
closing in favor of #185
Also rename EnableGC => ForceGC (GC is never disabled)
This should improve CPU usage at the expanse of memory, but memory is supposed to be capped with GOMEMLIMIT (which also triggers GC when reached) so this shouldn't be worrying
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.