Closed msherif1234 closed 8 months ago
/ok-to-test
New image: quay.io/netobserv/netobserv-ebpf-agent:0fd928e
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=0fd928e make set-agent-image
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
0891b34
) 31.79% compared to head (d66c036
) 31.84%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/ok-to-test
New image: quay.io/netobserv/netobserv-ebpf-agent:a7e6749
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=a7e6749 make set-agent-image
/ok-to-test
/ok-to-test
New image: quay.io/netobserv/netobserv-ebpf-agent:ed3a6a6
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=ed3a6a6 make set-agent-image
/ok-to-test
New image: quay.io/netobserv/netobserv-ebpf-agent:35e2cc7
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=35e2cc7 make set-agent-image
/ok-to-test
New image: quay.io/netobserv/netobserv-ebpf-agent:075fb69
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=075fb69 make set-agent-image
/ok-to-test
New image: quay.io/netobserv/netobserv-ebpf-agent:e32f956
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=e32f956 make set-agent-image
@msherif1234: This pull request references NETOBSERV-1379 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.
@msherif1234: This pull request references NETOBSERV-1379 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.
@msherif1234: This pull request references NETOBSERV-1379 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.
@msherif1234 are these error codes we should expect ? https://elixir.bootlin.com/linux/v4.7/source/include/uapi/asm-generic/errno-base.h#L10
@msherif1234 are these error codes we should expect ? https://elixir.bootlin.com/linux/v4.7/source/include/uapi/asm-generic/errno-base.h#L10
Correct
@msherif1234: This pull request references NETOBSERV-1379 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.
/ok-to-test
New image: quay.io/netobserv/netobserv-ebpf-agent:054faa4
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=054faa4 make set-agent-image
/ok-to-test
New image: quay.io/netobserv/netobserv-ebpf-agent:138178c
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=138178c make set-agent-image
/ok-to-test
New image: quay.io/netobserv/netobserv-ebpf-agent:9bed2e9
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=9bed2e9 make set-agent-image
@msherif1234: This pull request references NETOBSERV-1379 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.
/label qe-approved
@msherif1234: This pull request references NETOBSERV-1379 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: msherif1234
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description
it was noticed with DNS over TCP that the handshake packets are too small and it doesn't contain any DNS data from UI DNS fields showed as
n/a
which is truethis PR propagate the DNS lookup return code so we can differentiate between cases like TCP handshake case and real errors enriching with DNS info.
when we get N/A
bpf_skb_load_bytes()
return an errorin the none working case the received packet is very small that is why we can't fetch DNS header info.
Those small packets are TCP handshake and those packets don't have data by definition this clear when u look at the pcap
Dependencies
https://github.com/netobserv/network-observability-console-plugin/pull/425 https://github.com/netobserv/flowlogs-pipeline/pull/533
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.