netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
119 stars 30 forks source link

Add a new exporter type: DirectFLP #223

Closed jotak closed 8 months ago

jotak commented 8 months ago

Description

DirectFLP starts the whole flowlogs-pipeline process directly from the Agent, eliminating the need for a network connection between them.

This can be useful when both Agent and FLP run on the same host, saving resources. This is mutually exclusive with other exporters such as with Kafka.

Dependencies

https://github.com/netobserv/flowlogs-pipeline/pull/538

(hold until this is merged => replace directive to remove)

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (a5378d6) 31.83% compared to head (fa1002c) 33.38%.

Files Patch % Lines
pkg/agent/agent.go 0.00% 8 Missing :warning:
pkg/exporter/direct_flp.go 73.91% 4 Missing and 2 partials :warning:
pkg/exporter/convert_flp.go 95.08% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #223 +/- ## ========================================== + Coverage 31.83% 33.38% +1.55% ========================================== Files 37 39 +2 Lines 3371 3463 +92 ========================================== + Hits 1073 1156 +83 - Misses 2234 2241 +7 - Partials 64 66 +2 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/223/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/223/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `33.38% <83.96%> (+1.55%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

msherif1234 commented 8 months ago

/lgtm

jotak commented 8 months ago

/unhold

msherif1234 commented 8 months ago

/lgtm

jotak commented 8 months ago

thanks @msherif1234 ! /approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)~~ [jotak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment