netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
119 stars 30 forks source link

NETOBSERV-59 Add tcp flow stream exporter #224

Closed jpinsonneau closed 4 months ago

jpinsonneau commented 8 months ago

Description

This PR add TCP flow stream exporter for cli.

Dependencies

https://github.com/netobserv/network-observability-cli/pull/1

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 8 months ago

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (0c43b4a) 33.62% compared to head (ce87754) 33.17%.

Files Patch % Lines
pkg/exporter/flows.go 0.00% 37 Missing :warning:
pkg/agent/agent.go 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #224 +/- ## ========================================== - Coverage 33.62% 33.17% -0.46% ========================================== Files 39 40 +1 Lines 3494 3542 +48 ========================================== Hits 1175 1175 - Misses 2251 2299 +48 Partials 68 68 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/224/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/224/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `33.17% <0.00%> (-0.46%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jotak commented 8 months ago

Why not using the existing grpc exporter with the CLI ? Does it come with additional challenges?

msherif1234 commented 8 months ago

Why not using the existing grpc exporter with the CLI ? Does it come with additional challenges?

I asked the exact same question https://github.com/netobserv/network-observability-cli/pull/1#discussion_r1397326137

thinking more about this it might even be better to run in the same process of ebpf agent and consume directly ebpf records like what the direct flp did ? WDYT ?

jpinsonneau commented 4 months ago

Closing this in favor of https://github.com/netobserv/netobserv-ebpf-agent/pull/291