Closed jpinsonneau closed 4 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Attention: 48 lines
in your changes are missing coverage. Please review.
Comparison is base (
0c43b4a
) 33.62% compared to head (ce87754
) 33.17%.
Files | Patch % | Lines |
---|---|---|
pkg/exporter/flows.go | 0.00% | 37 Missing :warning: |
pkg/agent/agent.go | 0.00% | 11 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why not using the existing grpc exporter with the CLI ? Does it come with additional challenges?
Why not using the existing grpc exporter with the CLI ? Does it come with additional challenges?
I asked the exact same question https://github.com/netobserv/network-observability-cli/pull/1#discussion_r1397326137
thinking more about this it might even be better to run in the same process of ebpf agent and consume directly ebpf records like what the direct flp did ? WDYT ?
Closing this in favor of https://github.com/netobserv/netobserv-ebpf-agent/pull/291
Description
This PR add TCP flow stream exporter for cli.
Dependencies
https://github.com/netobserv/network-observability-cli/pull/1
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.