netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
119 stars 30 forks source link

s390x arch work around till bpf2go pr#1308 is available #248

Closed msherif1234 closed 6 months ago

msherif1234 commented 6 months ago

Description

bpf2go tool doesn't generate the right extension for auto generate go file till https://github.com/cilium/ebpf/pull/1308 is in place I will just use this work around

UT

MULTIARCH_TARGETS="amd64 arm64 ppc64le s390x" IMAGE_ORG=netobserv VERSION=main make images

docker images
REPOSITORY                               TAG            IMAGE ID       CREATED          SIZE
quay.io/netobserv/netobserv-ebpf-agent   main-s390x     7e20553e707f   9 minutes ago    173MB
quay.io/netobserv/netobserv-ebpf-agent   main-ppc64le   13331fda550b   10 minutes ago   194MB
quay.io/netobserv/netobserv-ebpf-agent   main-arm64     a4a676a8c70e   11 minutes ago   172MB
quay.io/netobserv/netobserv-ebpf-agent   main-amd64     8b881a32868d   12 minutes ago   171MB

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2864713) 33.77% compared to head (3a90bcd) 33.86%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #248 +/- ## ========================================== + Coverage 33.77% 33.86% +0.08% ========================================== Files 39 39 Lines 3479 3479 ========================================== + Hits 1175 1178 +3 + Misses 2235 2233 -2 + Partials 69 68 -1 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/248/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/248/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `33.86% <ø> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jotak commented 6 months ago

/lgtm

msherif1234 commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)~~ [msherif1234] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment