netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
119 stars 30 forks source link

pickup cilium fix for bpf2go tool for s390x target and remove Makefile workaround #255

Closed msherif1234 closed 6 months ago

msherif1234 commented 6 months ago

Description

Update cilium package to pick up https://github.com/cilium/ebpf/pull/1312 and remove tmp hack in the Makefile to work around s390x target build issues

unit-test

make sure I can build for all targets MULTIARCH_TARGETS="amd64 arm64 ppc64le s390x" IMAGE_ORG=netobserv VERSION=main make image

docker images
REPOSITORY                               TAG            IMAGE ID       CREATED              SIZE
quay.io/netobserv/netobserv-ebpf-agent   main-s390x     12cd754c3310   38 seconds ago       173MB
quay.io/netobserv/netobserv-ebpf-agent   main-ppc64le   d2534c147e76   About a minute ago   194MB
quay.io/netobserv/netobserv-ebpf-agent   main-arm64     63bfc05619ff   About a minute ago   172MB
quay.io/netobserv/netobserv-ebpf-agent   main-amd64     0154220e462f   2 minutes ago        171MB

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (6f1d70a) 33.86% compared to head (e2bd981) 33.65%. Report is 6 commits behind head on main.

Files Patch % Lines
pkg/exporter/proto.go 0.00% 16 Missing and 2 partials :warning:
pkg/flow/deduper.go 84.21% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #255 +/- ## ========================================== - Coverage 33.86% 33.65% -0.21% ========================================== Files 39 40 +1 Lines 3479 3542 +63 ========================================== + Hits 1178 1192 +14 - Misses 2233 2281 +48 - Partials 68 69 +1 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/255/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/255/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `33.65% <54.34%> (-0.21%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jotak commented 6 months ago

/lgtm

msherif1234 commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)~~ [msherif1234] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment