Closed msherif1234 closed 6 months ago
Attention: 21 lines
in your changes are missing coverage. Please review.
Comparison is base (
6f1d70a
) 33.86% compared to head (e2bd981
) 33.65%. Report is 6 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
pkg/exporter/proto.go | 0.00% | 16 Missing and 2 partials :warning: |
pkg/flow/deduper.go | 84.21% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: msherif1234
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description
Update cilium package to pick up https://github.com/cilium/ebpf/pull/1312 and remove tmp hack in the Makefile to work around
s390x
target build issuesunit-test
make sure I can build for all targets
MULTIARCH_TARGETS="amd64 arm64 ppc64le s390x" IMAGE_ORG=netobserv VERSION=main make image
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.