netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
119 stars 30 forks source link

Add config enable to enable pkt drop in ebpf [BackPort 1.5] #259

Closed msherif1234 closed 5 months ago

msherif1234 commented 6 months ago

Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com (cherry picked from commit 5890a0f321b9fbad0a25a9c5411dcdc73c87b109)

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

msherif1234 commented 6 months ago

/ok-to-test

github-actions[bot] commented 6 months ago

New image: quay.io/netobserv/netobserv-ebpf-agent:2693349

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=2693349 make set-agent-image
codecov[bot] commented 6 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (726bdb7) 33.65% compared to head (5aaf4e0) 33.59%.

Files Patch % Lines
pkg/ebpf/tracer.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.5 #259 +/- ## =============================================== - Coverage 33.65% 33.59% -0.06% =============================================== Files 40 40 Lines 3542 3548 +6 =============================================== Hits 1192 1192 - Misses 2281 2287 +6 Partials 69 69 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/259/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/259/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `33.59% <0.00%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from msherif1234. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/release-1.5/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msherif1234 commented 5 months ago

/ok-to-test

github-actions[bot] commented 5 months ago

New image: quay.io/netobserv/netobserv-ebpf-agent:bb0d15c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=bb0d15c make set-agent-image
msherif1234 commented 5 months ago

not needed on another run I did confirm the prog isn't loaded I assume I either had incorrect config or ran into other issue

oc exec -i -n default dbgtools-deployment-6bdc7d9bdc-r9nr6 -- bpftool perf show
$