netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
119 stars 30 forks source link

Filter out sockets for loopback and unknown interfaces (Backport 1.5) #261

Closed msherif1234 closed 5 months ago

msherif1234 commented 5 months ago

Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com (cherry picked from commit 9596d79fc35b851b5f83ac0946be691dcc14324f)

Description

filter out noisy flows for lo interface when enable RTT or pkt drop

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (726bdb7) 33.65% compared to head (5d47cc9) 33.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.5 #261 +/- ## ============================================ Coverage 33.65% 33.65% ============================================ Files 40 40 Lines 3542 3542 ============================================ Hits 1192 1192 Misses 2281 2281 Partials 69 69 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/261/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `33.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

msherif1234 commented 5 months ago

/ok-to-test

github-actions[bot] commented 5 months ago

New image: quay.io/netobserv/netobserv-ebpf-agent:4dde2f0

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4dde2f0 make set-agent-image
jotak commented 5 months ago

/lgtm

msherif1234 commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/release-1.5/OWNERS)~~ [msherif1234] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment