netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent

Apache License 2.0

119 stars 30 forks source link

NETOBSERV-557: add eBPF agent metrics for troubleshooting #263

Closed msherif1234 closed 5 months ago

msherif1234 commented 5 months ago

Description

add promo metrics to eBPF agent with the ability to export metrics to promo Server

unit-test

tested locally using standalone ebpf-agent

sudo LOG_LEVEL=debug FLOWS_TARGET_HOST=127.0.0.1 FLOWS_TARGET_PORT=9999 METRICS_PROMO_ENABLE="true" ./bin/netobserv-ebpf-agent

from another terminal curl 127.0.0.1:9090/metrics | grep ebpf_agent results


:-- # TYPE ebpf_agent_err_can_not_delete_flow_entries counter
-ebpf_agent_err_can_not_delete_flow_entries{operational="errors while deleting flows"} 0
-:# HELP ebpf_agent_err_can_not_write_to_grpc Error can not write to GRPC
--# TYPE ebpf_agent_err_can_not_write_to_grpc counter
:-ebpf_agent_err_can_not_write_to_grpc{operational="err_export_by_grpc"} 0

HELP ebpf_agent_hashmap_evictions Number of hashmap evictions

8# TYPE ebpf_agent_hashmap_evictions counter 8ebpf_agent_hashmap_evictions{operational="hash map evictions"} 16 06# HELP ebpf_agent_number_of_evicted_flows Number of evicted flows k# TYPE ebpf_agent_number_of_evicted_flows gauge

ebpf_agent_number_of_evicted_flows{operational="number of evicted flows"} 41

HELP ebpf_agent_number_of_flows_received_via_ring_buffer Number of flows received via ring buffer

TYPE ebpf_agent_number_of_flows_received_via_ring_buffer gauge

ebpf_agent_number_of_flows_received_via_ring_buffer{operational="number_of_flows_received"} 0

HELP ebpf_agent_number_of_records_received_by_grpc Number of records received by GRPC

TYPE ebpf_agent_number_of_records_received_by_grpc counter

ebpf_agent_number_of_records_received_by_grpc{operational="number_of_records_received_by_grpc"} 41

HELP ebpf_agent_sampling_rate Sampling rate

TYPE ebpf_agent_sampling_rate gauge

ebpf_agent_sampling_rate{operational="sampling rate"} 50

HELP ebpf_agent_time_spent_in_lookup_and_delete_map Time spent in lookup and delete map

TYPE ebpf_agent_time_spent_in_lookup_and_delete_map histogram

ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.001"} 16 ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.01"} 16 ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.1"} 16 ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="1"} 16 ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="10"} 16 ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="100"} 16 ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="1000"} 16 ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="10000"} 16 ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="+Inf"} 16 ebpf_agent_time_spent_in_lookup_and_delete_map_sum{operational="time spent in lookup and delete"} 0.005711665 ebpf_agent_time_spent_in_lookup_and_delete_map_count{operational="time spent in lookup and delete"} 16

HELP ebpf_agent_userspace_evictions Number of userspace evictions

TYPE ebpf_agent_userspace_evictions counter

ebpf_agent_userspace_evictions{operational="user space evictions"} 0


## Dependencies

n/a

## Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

* [ ] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
* [X] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix _(in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes)._
* [ ] Does this PR require product documentation?
  * [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
* [ ] Does this PR require a product release notes entry?
  * [ ] If so, fill in "Release Note Text" in the JIRA.
* [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  * [ ] If so, make sure it is described in the JIRA ticket.
* QE requirements (check 1 from the list):
  * [X] Standard QE validation, with pre-merge tests unless stated otherwise.
  * [ ] Regression tests only (e.g. refactoring with no user-facing change).
  * [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

openshift-ci-robot commented 5 months ago

@msherif1234: This pull request references NETOBSERV-557 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/netobserv-ebpf-agent/pull/263): >## Description > >add promo metrics to eBPF agent with the ability to export metrics to promo Server >## Dependencies > >n/a > >## Checklist > >If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that. > >* [ ] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist. >* [ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix _(in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes)._ >* [ ] Does this PR require product documentation? > * [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs. >* [ ] Does this PR require a product release notes entry? > * [ ] If so, fill in "Release Note Text" in the JIRA. >* [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc. > * [ ] If so, make sure it is described in the JIRA ticket. >* QE requirements (check 1 from the list): > * [ ] Standard QE validation, with pre-merge tests unless stated otherwise. > * [ ] Regression tests only (e.g. refactoring with no user-facing change). > * [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team). > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetobserv-ebpf-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (349fd30) 33.53% compared to head (77d43d1) 35.90%.

Files	Patch %	Lines
pkg/agent/agent.go	39.53%	25 Missing and 1 partial :warning:
pkg/prometheus/prom_server.go	70.58%	14 Missing and 6 partials :warning:
pkg/metrics/metrics.go	91.20%	6 Missing and 2 partials :warning:
pkg/ebpf/tracer.go	0.00%	4 Missing :warning:
pkg/flow/tracer_ringbuf.go	66.66%	2 Missing :warning:
pkg/exporter/grpc_proto.go	90.90%	1 Missing :warning:
pkg/exporter/kafka_proto.go	66.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #263 +/- ## ========================================== + Coverage 33.53% 35.90% +2.36% ========================================== Files 40 42 +2 Lines 3554 3777 +223 ========================================== + Hits 1192 1356 +164 - Misses 2293 2343 +50 - Partials 69 78 +9 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/263/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/263/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `35.90% <75.20%> (+2.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openshift-ci-robot commented 5 months ago

@msherif1234: This pull request references NETOBSERV-557 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/netobserv-ebpf-agent/pull/263): >## Description > >add promo metrics to eBPF agent with the ability to export metrics to promo Server > >### unit-test >tested locally using standalone ebpf-agent >- `sudo LOG_LEVEL=debug FLOWS_TARGET_HOST=127.0.0.1 FLOWS_TARGET_PORT=9999 METRICS_PROMO_ENABLE="true" ./bin/netobserv-ebpf-agent` >- from another terminal `curl 127.0.0.1:9090/metrics | grep ebpf_agent` >results >```sh >:-# TYPE ebpf_agent_bytes_submitted_via_grpc counter >-:ebpf_agent_bytes_submitted_via_grpc{operational="bytes_received_by_grpc"} 192 >--# HELP ebpf_agent_err_can_not_delete_flow_entries Error can not delete flow entries > -# TYPE ebpf_agent_err_can_not_delete_flow_entries counter >-:-ebpf_agent_err_can_not_delete_flow_entries{operational="errors while deleting flows"} 0 >-# HELP ebpf_agent_err_can_not_write_to_grpc Error can not write to GRPC >:-# TYPE ebpf_agent_err_can_not_write_to_grpc counter >- ebpf_agent_err_can_not_write_to_grpc{operational="err_export_by_grpc"} 0 >86# HELP ebpf_agent_hashmap_evictions Number of hashmap evictions >23# TYPE ebpf_agent_hashmap_evictions counter >k >ebpf_agent_hashmap_evictions{operational="hash map evictions"} 6 ># HELP ebpf_agent_number_of_evicted_flows Number of evicted flows ># TYPE ebpf_agent_number_of_evicted_flows gauge >ebpf_agent_number_of_evicted_flows{operational="number of evicted flows"} 192 ># HELP ebpf_agent_number_of_flows_received_via_ring_buffer Number of flows received via ring buffer ># TYPE ebpf_agent_number_of_flows_received_via_ring_buffer gauge >ebpf_agent_number_of_flows_received_via_ring_buffer{operational="number_of_flows_received"} 0 ># HELP ebpf_agent_time_spent_in_lookup_and_delete_map Time spent in lookup and delete map ># TYPE ebpf_agent_time_spent_in_lookup_and_delete_map histogram >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.001"} 1 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.01"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.1"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="1"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="10"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="100"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="1000"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="10000"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="+Inf"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_sum{operational="time spent in lookup and delete"} 0.013046000999999998 >ebpf_agent_time_spent_in_lookup_and_delete_map_count{operational="time spent in lookup and delete"} 6 ># HELP ebpf_agent_userspace_evictions Number of userspace evictions ># TYPE ebpf_agent_userspace_evictions counter >ebpf_agent_userspace_evictions{operational="user space evictions"} 0 > >``` >## Dependencies > >n/a > >## Checklist > >If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that. > >* [ ] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist. >* [ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix _(in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes)._ >* [ ] Does this PR require product documentation? > * [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs. >* [ ] Does this PR require a product release notes entry? > * [ ] If so, fill in "Release Note Text" in the JIRA. >* [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc. > * [ ] If so, make sure it is described in the JIRA ticket. >* QE requirements (check 1 from the list): > * [ ] Standard QE validation, with pre-merge tests unless stated otherwise. > * [ ] Regression tests only (e.g. refactoring with no user-facing change). > * [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team). > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetobserv-ebpf-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@msherif1234: This pull request references NETOBSERV-557 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/netobserv-ebpf-agent/pull/263): >## Description > >add promo metrics to eBPF agent with the ability to export metrics to promo Server > >### unit-test >tested locally using standalone ebpf-agent >- `sudo LOG_LEVEL=debug FLOWS_TARGET_HOST=127.0.0.1 FLOWS_TARGET_PORT=9999 METRICS_PROMO_ENABLE="true" ./bin/netobserv-ebpf-agent` >- from another terminal `curl 127.0.0.1:9090/metrics | grep ebpf_agent` >results >```sh >:-# TYPE ebpf_agent_bytes_submitted_via_grpc counter >-:ebpf_agent_bytes_submitted_via_grpc{operational="bytes_received_by_grpc"} 192 >--# HELP ebpf_agent_err_can_not_delete_flow_entries Error can not delete flow entries > -# TYPE ebpf_agent_err_can_not_delete_flow_entries counter >-:-ebpf_agent_err_can_not_delete_flow_entries{operational="errors while deleting flows"} 0 >-# HELP ebpf_agent_err_can_not_write_to_grpc Error can not write to GRPC >:-# TYPE ebpf_agent_err_can_not_write_to_grpc counter >- ebpf_agent_err_can_not_write_to_grpc{operational="err_export_by_grpc"} 0 >86# HELP ebpf_agent_hashmap_evictions Number of hashmap evictions >23# TYPE ebpf_agent_hashmap_evictions counter >k >ebpf_agent_hashmap_evictions{operational="hash map evictions"} 6 ># HELP ebpf_agent_number_of_evicted_flows Number of evicted flows ># TYPE ebpf_agent_number_of_evicted_flows gauge >ebpf_agent_number_of_evicted_flows{operational="number of evicted flows"} 192 ># HELP ebpf_agent_number_of_flows_received_via_ring_buffer Number of flows received via ring buffer ># TYPE ebpf_agent_number_of_flows_received_via_ring_buffer gauge >ebpf_agent_number_of_flows_received_via_ring_buffer{operational="number_of_flows_received"} 0 ># HELP ebpf_agent_time_spent_in_lookup_and_delete_map Time spent in lookup and delete map ># TYPE ebpf_agent_time_spent_in_lookup_and_delete_map histogram >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.001"} 1 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.01"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.1"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="1"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="10"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="100"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="1000"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="10000"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="+Inf"} 6 >ebpf_agent_time_spent_in_lookup_and_delete_map_sum{operational="time spent in lookup and delete"} 0.013046000999999998 >ebpf_agent_time_spent_in_lookup_and_delete_map_count{operational="time spent in lookup and delete"} 6 ># HELP ebpf_agent_userspace_evictions Number of userspace evictions ># TYPE ebpf_agent_userspace_evictions counter >ebpf_agent_userspace_evictions{operational="user space evictions"} 0 > >``` >## Dependencies > >n/a > >## Checklist > >If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that. > >* [ ] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist. >* [X] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix _(in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes)._ >* [ ] Does this PR require product documentation? > * [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs. >* [ ] Does this PR require a product release notes entry? > * [ ] If so, fill in "Release Note Text" in the JIRA. >* [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc. > * [ ] If so, make sure it is described in the JIRA ticket. >* QE requirements (check 1 from the list): > * [X] Standard QE validation, with pre-merge tests unless stated otherwise. > * [ ] Regression tests only (e.g. refactoring with no user-facing change). > * [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team). > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetobserv-ebpf-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 5 months ago

@msherif1234: This pull request references NETOBSERV-557 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/netobserv-ebpf-agent/pull/263): >## Description > >add promo metrics to eBPF agent with the ability to export metrics to promo Server > >### unit-test >tested locally using standalone ebpf-agent >- `sudo LOG_LEVEL=debug FLOWS_TARGET_HOST=127.0.0.1 FLOWS_TARGET_PORT=9999 METRICS_PROMO_ENABLE="true" ./bin/netobserv-ebpf-agent` >- from another terminal `curl 127.0.0.1:9090/metrics | grep ebpf_agent` >results >```sh >:-- # TYPE ebpf_agent_err_can_not_delete_flow_entries counter >-ebpf_agent_err_can_not_delete_flow_entries{operational="errors while deleting flows"} 0 >-:# HELP ebpf_agent_err_can_not_write_to_grpc Error can not write to GRPC >--# TYPE ebpf_agent_err_can_not_write_to_grpc counter >:-ebpf_agent_err_can_not_write_to_grpc{operational="err_export_by_grpc"} 0 >- # HELP ebpf_agent_hashmap_evictions Number of hashmap evictions >8# TYPE ebpf_agent_hashmap_evictions counter >8ebpf_agent_hashmap_evictions{operational="hash map evictions"} 16 >06# HELP ebpf_agent_number_of_evicted_flows Number of evicted flows >k# TYPE ebpf_agent_number_of_evicted_flows gauge > >ebpf_agent_number_of_evicted_flows{operational="number of evicted flows"} 41 ># HELP ebpf_agent_number_of_flows_received_via_ring_buffer Number of flows received via ring buffer ># TYPE ebpf_agent_number_of_flows_received_via_ring_buffer gauge >ebpf_agent_number_of_flows_received_via_ring_buffer{operational="number_of_flows_received"} 0 ># HELP ebpf_agent_number_of_records_received_by_grpc Number of records received by GRPC ># TYPE ebpf_agent_number_of_records_received_by_grpc counter >ebpf_agent_number_of_records_received_by_grpc{operational="number_of_records_received_by_grpc"} 41 ># HELP ebpf_agent_sampling_rate Sampling rate ># TYPE ebpf_agent_sampling_rate gauge >ebpf_agent_sampling_rate{operational="sampling rate"} 50 ># HELP ebpf_agent_time_spent_in_lookup_and_delete_map Time spent in lookup and delete map ># TYPE ebpf_agent_time_spent_in_lookup_and_delete_map histogram >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.001"} 16 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.01"} 16 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="0.1"} 16 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="1"} 16 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="10"} 16 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="100"} 16 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="1000"} 16 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="10000"} 16 >ebpf_agent_time_spent_in_lookup_and_delete_map_bucket{operational="time spent in lookup and delete",le="+Inf"} 16 >ebpf_agent_time_spent_in_lookup_and_delete_map_sum{operational="time spent in lookup and delete"} 0.005711665 >ebpf_agent_time_spent_in_lookup_and_delete_map_count{operational="time spent in lookup and delete"} 16 ># HELP ebpf_agent_userspace_evictions Number of userspace evictions ># TYPE ebpf_agent_userspace_evictions counter >ebpf_agent_userspace_evictions{operational="user space evictions"} 0 >``` >## Dependencies > >n/a > >## Checklist > >If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that. > >* [ ] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist. >* [X] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix _(in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes)._ >* [ ] Does this PR require product documentation? > * [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs. >* [ ] Does this PR require a product release notes entry? > * [ ] If so, fill in "Release Note Text" in the JIRA. >* [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc. > * [ ] If so, make sure it is described in the JIRA ticket. >* QE requirements (check 1 from the list): > * [X] Standard QE validation, with pre-merge tests unless stated otherwise. > * [ ] Regression tests only (e.g. refactoring with no user-facing change). > * [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team). > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetobserv-ebpf-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

github-actions[bot] commented 5 months ago

New image: quay.io/netobserv/netobserv-ebpf-agent:1ed6690

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=1ed6690 make set-agent-image

jotak commented 5 months ago

p99 of lookup&delete map is kinda scary... almost 1s

msherif1234 commented 5 months ago

p99 of lookup&delete map is kinda scary... almost 1s

is this at scale ?we know this path is most busy path and resouces hog in the agent

msherif1234 commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)~~ [msherif1234] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment