search

netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
127 stars 32 forks source link

Share errors counter across components #278

Closed jotak closed 7 months ago

jotak commented 7 months ago

image

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 36.08%. Comparing base (9507ebf) to head (be61272). Report is 1 commits behind head on main.

Files Patch % Lines
pkg/exporter/kafka_proto.go 0.00% 2 Missing :warning:
pkg/agent/agent.go 0.00% 1 Missing :warning:
pkg/exporter/grpc_proto.go 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #278 +/- ## ========================================== + Coverage 35.90% 36.08% +0.17% ========================================== Files 42 42 Lines 3777 3786 +9 ========================================== + Hits 1356 1366 +10 + Misses 2343 2342 -1 Partials 78 78 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/278/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/278/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `36.08% <82.60%> (+0.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

msherif1234 commented 7 months ago

/lgtm

jotak commented 7 months ago

/approve thx

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)~~ [jotak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment