Closed jotak closed 7 months ago
@jotak: This pull request references NETOBSERV-1533 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@msherif1234 as I'm working on the dashboard and I'm bringing a few changes here. Here's a screenshot of what I get with these metrics:
Some text counters in the top bar:
Some ebpf stats:
(something looks wrong in the eviction rate when it evicts because of full map)
Attention: Patch coverage is 69.10569%
with 38 lines
in your changes are missing coverage. Please review.
Project coverage is 36.26%. Comparing base (
b3c02b8
) to head (4a58e68
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
pkg/agent/agent.go | 35.48% | 20 Missing :warning: |
pkg/ebpf/tracer.go | 0.00% | 9 Missing :warning: |
pkg/flow/tracer_ringbuf.go | 50.00% | 5 Missing :warning: |
pkg/exporter/kafka_proto.go | 50.00% | 2 Missing :warning: |
pkg/exporter/grpc_proto.go | 90.90% | 1 Missing :warning: |
pkg/flow/account.go | 93.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm
New image: quay.io/netobserv/netobserv-ebpf-agent:12b1753
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=12b1753 make set-agent-image
@msherif1234 I think this task is done I've got all metrics needed to build a nice dashboard - can you take a second look & review please?
New image: quay.io/netobserv/netobserv-ebpf-agent:26076c3
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=26076c3 make set-agent-image
overall looks great to me small comments/questions inline up to you to address nothing critical /lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jotak
The full list of commands accepted by this bot can be found here.
The pull request process is described here