Closed jpinsonneau closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 36.74%. Comparing base (
e9bf0d0
) to head (b9179c7
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm assuming e2e will pass, also I am not sure why u updated FLP in this PR but have no prob with that
/lgtm assuming e2e will pass, also I am not sure why u updated FLP in this PR but have no prob with that
@msherif1234 I have issues with IPFIX export, I wonder if it's broken :thinking: I get nil even if I check for old fields
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description
Fix e2e:
gRPC
case:IfDirections
andInterfaces
and check for arraysIPFIX
case:FlowDirection
andInterface
I would recommend to move away these tests to a new dedicated repo to avoid going back and forth updating dependencies. These could also include console plugin cypress tests, operator deployment and CLI in future.
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.