netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
116 stars 29 forks source link

Change HOST/PORT env to TARGET_HOST / TARGET_PORT #303

Closed jotak closed 3 months ago

jotak commented 3 months ago

As discussed here: https://github.com/netobserv/netobserv-ebpf-agent/pull/291#discussion_r1520076865 HOST and PORT are very generic and don't provide the meaning about what they are for; An uninformed user would probably think this would be for a server, or for the agent host itself, rather than a target of flow/packet collectors.

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

github-actions[bot] commented 3 months ago

New image: quay.io/netobserv/netobserv-ebpf-agent:ff5ff28

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=ff5ff28 make set-agent-image
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 34.04%. Comparing base (08030df) to head (880e127). Report is 1 commits behind head on main.

Files Patch % Lines
pkg/agent/agent.go 0.00% 6 Missing :warning:
pkg/agent/config.go 0.00% 3 Missing :warning:
pkg/agent/packets_agent.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #303 +/- ## ======================================= Coverage 34.04% 34.04% ======================================= Files 47 47 Lines 3836 3836 ======================================= Hits 1306 1306 Misses 2444 2444 Partials 86 86 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/303/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/303/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `34.04% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

msherif1234 commented 3 months ago

/lgtm

msherif1234 commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)~~ [msherif1234] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jpinsonneau commented 3 months ago

Sure, thanks for the update @jotak