Closed jotak closed 3 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.84%. Comparing base (
1cc8125
) to head (2ce74a7
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
New image: quay.io/netobserv/netobserv-ebpf-agent:3ba1248
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=3ba1248 make set-agent-image
@jotak: This pull request references NETOBSERV-1595 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
@jotak: This pull request references NETOBSERV-1595 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
I intentionally removed the .o files from source and generated a build just to make sure it uses CI-generated .o I'll put back .o in git so that they are still available for local runs.
/LGTM
/test images
/test images
New image: quay.io/netobserv/netobserv-ebpf-agent:9a271c2
It will expire after two weeks.
To deploy this build, run from the operator repo, assuming the operator is running:
USER=netobserv VERSION=9a271c2 make set-agent-image
/approve
@msherif1234 one downside of this is increased image build time, that can perhaps be painful when you build locally. If this ends up too painful we could create a separate dockerfile for local builds, that would diverge from CI dockerfile.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jotak
The full list of commands accepted by this bot can be found here.
The pull request process is described here
make generate
in 2 (one for BPF another for protoc ; we don't need to build protobuf from CI as this is still code)