netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
116 stars 29 forks source link

NETOBSERV-1595: generate BPF from CI #309

Closed jotak closed 3 months ago

jotak commented 3 months ago
openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.84%. Comparing base (1cc8125) to head (2ce74a7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #309 +/- ## ======================================= Coverage 33.84% 33.84% ======================================= Files 47 47 Lines 3865 3865 ======================================= Hits 1308 1308 Misses 2469 2469 Partials 88 88 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/309/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `33.84% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

New image: quay.io/netobserv/netobserv-ebpf-agent:3ba1248

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=3ba1248 make set-agent-image
openshift-ci-robot commented 3 months ago

@jotak: This pull request references NETOBSERV-1595 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/netobserv-ebpf-agent/pull/309): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetobserv-ebpf-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@jotak: This pull request references NETOBSERV-1595 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/netobserv-ebpf-agent/pull/309): >- Add BPF generation steps in the main Dockerfile >- Split `make generate` in 2 (one for BPF another for protoc ; we don't need to build protobuf from CI as this is still code) >- Add a pull-request check to verify that the provided BPF bin match the code Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetobserv-ebpf-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jotak commented 3 months ago

I intentionally removed the .o files from source and generated a build just to make sure it uses CI-generated .o I'll put back .o in git so that they are still available for local runs.

msherif1234 commented 3 months ago

/LGTM

msherif1234 commented 3 months ago

/test images

msherif1234 commented 3 months ago

/test images

github-actions[bot] commented 3 months ago

New image: quay.io/netobserv/netobserv-ebpf-agent:9a271c2

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=9a271c2 make set-agent-image
jotak commented 3 months ago

/approve

@msherif1234 one downside of this is increased image build time, that can perhaps be painful when you build locally. If this ends up too painful we could create a separate dockerfile for local builds, that would diverge from CI dockerfile.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)~~ [jotak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment