netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
115 stars 29 forks source link

Allow flow filtering to coexists with pkt drop and rtt ebpf hooks #318

Closed msherif1234 closed 2 months ago

msherif1234 commented 2 months ago

Description

we need to make sure flow filtering also used when pkt drop or rtt ebpf hooks are in use

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

msherif1234 commented 2 months ago

/test unit

msherif1234 commented 2 months ago

/ok-to-test

github-actions[bot] commented 2 months ago

New image: quay.io/netobserv/netobserv-ebpf-agent:eab28bf

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=eab28bf make set-agent-image
codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.41%. Comparing base (e41327e) to head (28bb65f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #318 +/- ## ======================================= Coverage 33.41% 33.41% ======================================= Files 48 48 Lines 3477 3477 ======================================= Hits 1162 1162 Misses 2218 2218 Partials 97 97 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/318/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `33.41% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

msherif1234 commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)~~ [msherif1234] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment