search

netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
115 stars 29 forks source link

NETOBSERV-1617: reuse flow filter capability with pcap feature #359

Closed msherif1234 closed 1 week ago

msherif1234 commented 1 week ago

Description

NOO and CLI repos need to be updated with the renamed configs

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci-robot commented 1 week ago

@msherif1234: This pull request references NETOBSERV-1617 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/netobserv-ebpf-agent/pull/359): >## Description > >- rename all flow filters to just filter to allow reuse the same configs >- modify pca to use filter config >- update userspace, examples and doc > >NOO and CLI repos need to be updated with the renamed configs >## Dependencies > >n/a > >## Checklist > >If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that. > >* [ ] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist. >* [ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix _(in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes)._ >* [ ] Does this PR require product documentation? > * [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs. >* [ ] Does this PR require a product release notes entry? > * [ ] If so, fill in "Release Note Text" in the JIRA. >* [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc. > * [ ] If so, make sure it is described in the JIRA ticket. >* QE requirements (check 1 from the list): > * [ ] Standard QE validation, with pre-merge tests unless stated otherwise. > * [ ] Regression tests only (e.g. refactoring with no user-facing change). > * [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team). > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetobserv-ebpf-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 19.75309% with 65 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@58e5d37). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #359 +/- ## ======================================= Coverage ? 33.13% ======================================= Files ? 48 Lines ? 3543 Branches ? 0 ======================================= Hits ? 1174 Misses ? 2267 Partials ? 102 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/359/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `33.13% <19.75%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/359?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [pkg/agent/config.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/359?src=pr&el=tree&filepath=pkg%2Fagent%2Fconfig.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2FnZW50L2NvbmZpZy5nbw==) | `10.00% <ø> (ø)` | | | [pkg/ebpf/bpf\_x86\_bpfel.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/359?src=pr&el=tree&filepath=pkg%2Febpf%2Fbpf_x86_bpfel.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2VicGYvYnBmX3g4Nl9icGZlbC5nbw==) | `0.00% <ø> (ø)` | | | [pkg/agent/agent.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/359?src=pr&el=tree&filepath=pkg%2Fagent%2Fagent.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2FnZW50L2FnZW50Lmdv) | `35.97% <0.00%> (ø)` | | | [pkg/ebpf/flow\_filter.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/359?src=pr&el=tree&filepath=pkg%2Febpf%2Fflow_filter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2VicGYvZmxvd19maWx0ZXIuZ28=) | `44.06% <48.48%> (ø)` | | | [pkg/ebpf/tracer.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/359?src=pr&el=tree&filepath=pkg%2Febpf%2Ftracer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2VicGYvdHJhY2VyLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/agent/packets\_agent.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/359?src=pr&el=tree&filepath=pkg%2Fagent%2Fpackets_agent.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2FnZW50L3BhY2tldHNfYWdlbnQuZ28=) | `0.00% <0.00%> (ø)` | |
msherif1234 commented 1 week ago

/ok-to-test

github-actions[bot] commented 1 week ago

New image: quay.io/netobserv/netobserv-ebpf-agent:f525832

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=f525832 make set-agent-image
msherif1234 commented 1 week ago

/ok-to-test

github-actions[bot] commented 1 week ago

New image: quay.io/netobserv/netobserv-ebpf-agent:82edc9f

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=82edc9f make set-agent-image
openshift-ci[bot] commented 1 week ago

New changes are detected. LGTM label has been removed.

msherif1234 commented 1 week ago

/approve

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)~~ [msherif1234] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment