NETOBSERV-1703 Add enrichment in packet capture

jpinsonneau commented 3 weeks ago

Description

This PR allows pcap parsing to generic map. Check CLI implementation for usage.

Dependencies

https://github.com/netobserv/network-observability-cli/pull/61

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[ ] Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
[X] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?
- [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
[ ] Does this PR require a product release notes entry?
- [ ] If so, fill in "Release Note Text" in the JIRA.
[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
- [ ] If so, make sure it is described in the JIRA ticket.
QE requirements (check 1 from the list):
- [X] Standard QE validation, with pre-merge tests unless stated otherwise.
- [ ] Regression tests only (e.g. refactoring with no user-facing change).
- [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

openshift-ci[bot] commented 3 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@434968e). Learn more about missing BASE report. Report is 5 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #364 +/- ## ======================================= Coverage ? 32.16% ======================================= Files ? 48 Lines ? 3666 Branches ? 0 ======================================= Hits ? 1179 Misses ? 2386 Partials ? 101 ``` | [Flag](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `32.16% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [pkg/agent/config.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364?src=pr&el=tree&filepath=pkg%2Fagent%2Fconfig.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2FnZW50L2NvbmZpZy5nbw==) | `10.00% <ø> (ø)` | | | [pkg/agent/agent.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364?src=pr&el=tree&filepath=pkg%2Fagent%2Fagent.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2FnZW50L2FnZW50Lmdv) | `35.97% <0.00%> (ø)` | | | [pkg/exporter/direct\_flp.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364?src=pr&el=tree&filepath=pkg%2Fexporter%2Fdirect_flp.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2V4cG9ydGVyL2RpcmVjdF9mbHAuZ28=) | `55.00% <0.00%> (ø)` | | | [pkg/exporter/grpc\_packets.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364?src=pr&el=tree&filepath=pkg%2Fexporter%2Fgrpc_packets.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2V4cG9ydGVyL2dycGNfcGFja2V0cy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/agent/packets\_agent.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364?src=pr&el=tree&filepath=pkg%2Fagent%2Fpackets_agent.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2FnZW50L3BhY2tldHNfYWdlbnQuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/utils/packets.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364?src=pr&el=tree&filepath=pkg%2Futils%2Fpackets.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL3V0aWxzL3BhY2tldHMuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/decode/decode\_protobuf.go](https://app.codecov.io/gh/netobserv/netobserv-ebpf-agent/pull/364?src=pr&el=tree&filepath=pkg%2Fdecode%2Fdecode_protobuf.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2RlY29kZS9kZWNvZGVfcHJvdG9idWYuZ28=) | `24.36% <0.00%> (ø)` | |

jpinsonneau commented 2 weeks ago

@eranra & @KalmanMeth you might be interested by this PR :eyes:

msherif1234 commented 2 weeks ago

/lgtm

github-actions[bot] commented 2 weeks ago

New image: quay.io/netobserv/netobserv-ebpf-agent:30c0f75

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=30c0f75 make set-agent-image

Amoghrd commented 4 days ago

/ok-to-test

github-actions[bot] commented 4 days ago

New image: quay.io/netobserv/netobserv-ebpf-agent:95041fd

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=95041fd make set-agent-image

Amoghrd commented 4 days ago

/label qe-approved

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

netobserv / netobserv-ebpf-agent