netobserv / netobserv-ebpf-agent

Network Observability eBPF Agent
Apache License 2.0
128 stars 33 forks source link

Error in testing phase due to missing type conversion #85

Closed praveingk closed 1 year ago

praveingk commented 1 year ago

Faced the following build error :


:~/netobserv-new$ make build
### Check if prerequisites are met, and installing missing dependencies
### Formatting code
### Linting code
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 
WARN [linters_context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649. 
### Testing code
# github.com/netobserv/netobserv-ebpf-agent/pkg/grpc [github.com/netobserv/netobserv-ebpf-agent/pkg/grpc.test]
pkg/grpc/grpc_test.go:72:24: cannot use 0xaabbccdd (untyped int constant 2864434397) as int value in argument to assert.EqualValues (overflows)
pkg/grpc/grpc_test.go:83:24: cannot use 0x88776655 (untyped int constant 2289526357) as int value in argument to assert.EqualValues (overflows)
pkg/grpc/grpc_test.go:84:24: cannot use 0xddccbbaa (untyped int constant 3721182122) as int value in argument to assert.EqualValues (overflows)
# github.com/netobserv/netobserv-ebpf-agent/pkg/exporter [github.com/netobserv/netobserv-ebpf-agent/pkg/exporter.test]
pkg/exporter/kafka_proto_test.go:53:24: cannot use 0xaabbccddeeff (untyped int constant 187723572702975) as int value in argument to assert.EqualValues (overflows)
pkg/exporter/kafka_proto_test.go:54:24: cannot use 0x112233445566 (untyped int constant 18838586676582) as int value in argument to assert.EqualValues (overflows)
pkg/exporter/kafka_proto_test.go:55:24: cannot use 0xC0010203 (untyped int constant 3221291523) as int value in argument to assert.EqualValues (overflows)
?       github.com/netobserv/netobserv-ebpf-agent/cmd   [no test files]
ok      github.com/netobserv/netobserv-ebpf-agent/e2e/cluster   0.036s  coverage: 2.2% of statements in ./...
?       github.com/netobserv/netobserv-ebpf-agent/e2e/cluster/tester    [no test files]
?       github.com/netobserv/netobserv-ebpf-agent/examples/flowlogs-dump/server [no test files]
?       github.com/netobserv/netobserv-ebpf-agent/examples/ipfix-collector  [no test files]
?       github.com/netobserv/netobserv-ebpf-agent/examples/performance/server   [no test files]
ok      github.com/netobserv/netobserv-ebpf-agent/pkg/agent 0.089s  coverage: 19.8% of statements in ./...
?       github.com/netobserv/netobserv-ebpf-agent/pkg/ebpf  [no test files]
FAIL    github.com/netobserv/netobserv-ebpf-agent/pkg/exporter [build failed]
ok      github.com/netobserv/netobserv-ebpf-agent/pkg/flow  0.226s  coverage: 6.8% of statements in ./...
FAIL    github.com/netobserv/netobserv-ebpf-agent/pkg/grpc [build failed]
ok      github.com/netobserv/netobserv-ebpf-agent/pkg/ifaces    0.051s  coverage: 5.3% of statements in ./...
?       github.com/netobserv/netobserv-ebpf-agent/pkg/pbflow    [no test files]
?       github.com/netobserv/netobserv-ebpf-agent/pkg/test  [no test files]
FAIL
make: *** [Makefile:97: test] Error 2
pravein@tcnode7:~/netobserv-new$ vi pkg/grpc/grpc_test.go
jotak commented 1 year ago

Is it specific to a version of go? I don't have this failure on my side (or the platform)

praveingk commented 1 year ago

Myself and @shachee tried using go 18.4, golangci-lint 1.50.1 since the recent versions supports 1.18. Which version is recommended?

jotak commented 1 year ago

1.18 should be fine. idk what the problem is. in any case, your fix looks good, thanks

praveingk commented 1 year ago

Fixed and merged.