search

netobserv / network-observability-cli

An OpenShift / Kubernetes CLI tool for network observability
Apache License 2.0
7 stars 6 forks source link

`make build` fails on fresh env #11

Open yuvalk opened 5 months ago

yuvalk commented 5 months ago

https://github.com/netobserv/network-observability-cli/blob/ab18a4b3caea4c79370dd2ded15b79e55de151b1/Makefile#L73

this step fails on envs that doesnt have go.tmz.dev/musttag in their local cache

$ make build
which: no podman in (/home/yuval/.local/bin:/home/yuval/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin)
basename: missing operand
Try 'basename --help' for more information.
### Formatting code
go fmt ./...
### Test if prerequisites are met, and installing missing dependencies
GOFLAGS="" go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.2
go: downloading go.tmz.dev/musttag v0.7.2
/home/yuval/go/pkg/mod/github.com/golangci/golangci-lint@v1.54.2/pkg/golinters/musttag.go:4:2: unrecognized import path "go.tmz.dev/musttag": parse https://go.tmz.dev/musttag?go-get=1: no go-import meta tags ()
make: *** [Makefile:73: prereqs] Error 1

I'm using 

$ go version
go version go1.21.8 linux/amd64

on a new vm (so nothing in my caches yet)

github-actions[bot] commented 5 months ago

Congratulations for contributing your first netobserv-cli issue

jotak commented 5 months ago

Trying to reproduce, cleaning up & removing my "~/go/pkg/mod/github.com/golangci" and "go/pkg/mod/go.tmz.dev", but it worked for me, everything seem downloaded again as expected (I tried with go 1.21.7) Also on CI (which also starts with a fresh new env) this is working, example: https://github.com/netobserv/network-observability-cli/actions/runs/8433720228/job/23095366225#step:5:8

Can you post your go env so we can check if something differs?