netobserv / network-observability-cli

An OpenShift / Kubernetes CLI tool for network observability
Apache License 2.0
7 stars 6 forks source link

NETOBSERV-1678 : Allow custom image at run time #42

Closed jpinsonneau closed 3 months ago

jpinsonneau commented 3 months ago

Description

NETOBSERV_COLLECTOR_IMAGE=xxx oc netobserv flows

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.49%. Comparing base (153b313) to head (588b905). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #42 +/- ## ======================================= Coverage 31.49% 31.49% ======================================= Files 5 5 Lines 962 962 ======================================= Hits 303 303 Misses 637 637 Partials 22 22 ``` | [Flag](https://app.codecov.io/gh/netobserv/network-observability-cli/pull/42/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/network-observability-cli/pull/42/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `31.49% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/network-observability-cli/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment