NETOBSERV-1693 Prompt for copying files on exit followup

[jpinsonneau]

Description

@Amoghrd would that work for you ?

--copy=true|false|prompt

by default the prompt is asked at the end of the collection. If the user specify --copy=true or --copy=false, the corresponding action is done without prompt.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• [X] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• [ ] Does this PR require product documentation?
  • [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• [ ] Does this PR require a product release notes entry?
  • [ ] If so, fill in "Release Note Text" in the JIRA.
• [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • [ ] If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • [X] Standard QE validation, with pre-merge tests unless stated otherwise.
  • [ ] Regression tests only (e.g. refactoring with no user-facing change).
  • [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.53%. Comparing base (60a259a) to head (c5139ed).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #65 +/- ## ======================================= Coverage 28.53% 28.53% ======================================= Files 8 8 Lines 1076 1076 ======================================= Hits 307 307 Misses 747 747 Partials 22 22 ``` | [Flag](https://app.codecov.io/gh/netobserv/network-observability-cli/pull/65/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/network-observability-cli/pull/65/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `28.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more.

[Amoghrd]

/ok-to-test

[github-actions[bot]]

New image: quay.io/netobserv/network-observability-cli:4edb285

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=4edb285 make commands

or download the updated commands.

[Amoghrd]

The copy option does not show up in help and also in env log lines. Otherwise works as expected!

[jpinsonneau]

@msherif1234 & @Amoghrd

Rebased and added help, doc and an echo when param is set. Thanks for your feedback !

[github-actions[bot]]

New image: quay.io/netobserv/network-observability-cli:3b4eff4

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=3b4eff4 make commands

or download the updated commands.

[msherif1234]

/lgtm

[Amoghrd]

Works as expected. /label qe-approved

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/network-observability-cli/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment