search

netobserv / network-observability-console-plugin

Network Observability plugin for the Openshift Console
Apache License 2.0
5 stars 14 forks source link

NETOBSERV-387 Filter out namespaces #328

Closed eranra closed 8 months ago

eranra commented 1 year ago

Question: in the UI filter, can I filter out some namespace? I want to remove all the pods from kube-admin. For example

@jpinsonneau @kfirtoledo

github-actions[bot] commented 1 year ago

Congratulations for contributing your first netobserv-console-plugin issue

jpinsonneau commented 1 year ago

The query engine already support excluding values as you can see here: https://github.com/netobserv/network-observability-console-plugin/blob/main/config/sample-frontend-config.yaml#L10 https://github.com/netobserv/network-observability-console-plugin/blob/main/pkg/loki/filter.go#L16

src_namespace! / dst_namespace!

However, we need to find a way to set this from the UI as it's currently only implemented in quick filters.

I would suggest to add a button that would be either = or != (see the red square between the key and the value) as: image This would allow us to manage more cases in the future. WDYT ?

kfirtoledo commented 1 year ago

I think it is a good solution.

eranra commented 1 year ago

@jpinsonneau I also think that this is a good idea :-) thanks

jpinsonneau commented 1 year ago

@andrew-ronaldson FYI, maybe you have good comparaisons to bring :cat:

@eranra @kfirtoledo do you guys plan to implement this by yourself ? I can guide you if needed On our side we have identified it but it's not part of our priorities.

eranra commented 1 year ago

Hi @andrew-ronaldson Unfortunately, no one knows UI enough to implement. We will have to wait for you or @jpinsonneau to help with that. But, what we are doing is reorganizing the namespaces in our demo to fit. Priorities, yes :-)

jpinsonneau commented 1 year ago

Here we go https://github.com/netobserv/network-observability-console-plugin/pull/333 :guitar: