netobserv / network-observability-operator

An OpenShift / Kubernetes operator for network observability
Apache License 2.0
133 stars 24 forks source link

Regenerate docs #657

Closed jotak closed 1 month ago

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/network-observability-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msherif1234 commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.53%. Comparing base (1ac0142) to head (583efdc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #657 +/- ## ======================================= Coverage 66.53% 66.53% ======================================= Files 70 70 Lines 8095 8095 ======================================= Hits 5386 5386 Misses 2315 2315 Partials 394 394 ``` | [Flag](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/657/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/657/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `66.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/657?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [apis/flowcollector/v1beta2/flowcollector\_types.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/657?src=pr&el=tree&filepath=apis%2Fflowcollector%2Fv1beta2%2Fflowcollector_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93Y29sbGVjdG9yL3YxYmV0YTIvZmxvd2NvbGxlY3Rvcl90eXBlcy5nbw==) | `100.00% <ø> (ø)` | | | [apis/flowmetrics/v1alpha1/flowmetric\_types.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/657?src=pr&el=tree&filepath=apis%2Fflowmetrics%2Fv1alpha1%2Fflowmetric_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93bWV0cmljcy92MWFscGhhMS9mbG93bWV0cmljX3R5cGVzLmdv) | `100.00% <ø> (ø)` | |
jotak commented 1 month ago

@skrthomas last commit should address your comments; except for what is in the upstream k8s doc

skrthomas commented 1 month ago

/lgtm thank you, @jotak