search

netobserv / network-observability-operator

An OpenShift / Kubernetes operator for network observability
Apache License 2.0
133 stars 24 forks source link

WIP: NETOBSERV-1642: Ovs monitoring feature #664

Open msherif1234 opened 1 month ago

msherif1234 commented 1 month ago

Description

changes to support ovs monitoring config and console bits

FC config to enable ovs monitoring fearure

agent:
    type: eBPF
    ebpf:   
      privileged: true
      features:
       - "OvsMonitor"

Dependencies

https://github.com/netobserv/netobserv-ebpf-agent/pull/286

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci-robot commented 1 month ago

@msherif1234: This pull request references NETOBSERV-1642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/664): >## Description > >changes to support ovs monitoring config and console bits >## Dependencies > > >n/a > >## Checklist > >If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that. > >* [ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix _(in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes)._ >* [ ] Does this PR require product documentation? > * [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs. >* [ ] Does this PR require a product release notes entry? > * [ ] If so, fill in "Release Note Text" in the JIRA. >* [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc. > * [ ] If so, make sure it is described in the JIRA ticket. >* QE requirements (check 1 from the list): > * [ ] Standard QE validation, with pre-merge tests unless stated otherwise. > * [ ] Regression tests only (e.g. refactoring with no user-facing change). > * [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team). > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from msherif1234. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/network-observability-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@msherif1234: This pull request references NETOBSERV-1642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/664): >## Description > >changes to support ovs monitoring config and console bits >## Dependencies > >https://github.com/netobserv/netobserv-ebpf-agent/pull/286 > >## Checklist > >If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that. > >* [ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix _(in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes)._ >* [ ] Does this PR require product documentation? > * [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs. >* [ ] Does this PR require a product release notes entry? > * [ ] If so, fill in "Release Note Text" in the JIRA. >* [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc. > * [ ] If so, make sure it is described in the JIRA ticket. >* QE requirements (check 1 from the list): > * [ ] Standard QE validation, with pre-merge tests unless stated otherwise. > * [ ] Regression tests only (e.g. refactoring with no user-facing change). > * [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team). > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
msherif1234 commented 1 month ago

/ok-to-test

github-actions[bot] commented 1 month ago

New images:

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:90f3501 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-90f3501

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-90f3501
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 5.55556% with 34 lines in your changes missing coverage. Please review.

Project coverage is 65.78%. Comparing base (66c7a62) to head (87a3a90).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #664 +/- ## ========================================== - Coverage 66.05% 65.78% -0.27% ========================================== Files 70 70 Lines 8186 8222 +36 ========================================== + Hits 5407 5409 +2 - Misses 2383 2413 +30 - Partials 396 400 +4 ``` | [Flag](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/664/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/664/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `65.78% <5.55%> (-0.27%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/664?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [apis/flowcollector/v1beta1/flowcollector\_types.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/664?src=pr&el=tree&filepath=apis%2Fflowcollector%2Fv1beta1%2Fflowcollector_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93Y29sbGVjdG9yL3YxYmV0YTEvZmxvd2NvbGxlY3Rvcl90eXBlcy5nbw==) | `100.00% <ø> (ø)` | | | [apis/flowcollector/v1beta2/flowcollector\_types.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/664?src=pr&el=tree&filepath=apis%2Fflowcollector%2Fv1beta2%2Fflowcollector_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93Y29sbGVjdG9yL3YxYmV0YTIvZmxvd2NvbGxlY3Rvcl90eXBlcy5nbw==) | `100.00% <ø> (ø)` | | | [pkg/helper/flowcollector.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/664?src=pr&el=tree&filepath=pkg%2Fhelper%2Fflowcollector.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-cGtnL2hlbHBlci9mbG93Y29sbGVjdG9yLmdv) | `82.87% <100.00%> (+0.16%)` | :arrow_up: | | [controllers/consoleplugin/consoleplugin\_objects.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/664?src=pr&el=tree&filepath=controllers%2Fconsoleplugin%2Fconsoleplugin_objects.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-Y29udHJvbGxlcnMvY29uc29sZXBsdWdpbi9jb25zb2xlcGx1Z2luX29iamVjdHMuZ28=) | `86.58% <0.00%> (-0.43%)` | :arrow_down: | | [controllers/flp/flp\_pipeline\_builder.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/664?src=pr&el=tree&filepath=controllers%2Fflp%2Fflp_pipeline_builder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-Y29udHJvbGxlcnMvZmxwL2ZscF9waXBlbGluZV9idWlsZGVyLmdv) | `85.15% <0.00%> (-2.21%)` | :arrow_down: | | [controllers/ebpf/agent\_controller.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/664?src=pr&el=tree&filepath=controllers%2Febpf%2Fagent_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-Y29udHJvbGxlcnMvZWJwZi9hZ2VudF9jb250cm9sbGVyLmdv) | `56.35% <0.00%> (-3.29%)` | :arrow_down: |
msherif1234 commented 1 month ago

/ok-to-test

github-actions[bot] commented 1 month ago

New images:

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:495b735 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-495b735

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-495b735
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m
msherif1234 commented 1 month ago

/ok-to-test

github-actions[bot] commented 1 month ago

New images:

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:32ec69e make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-32ec69e

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-32ec69e
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m
openshift-ci-robot commented 1 month ago

@msherif1234: This pull request references NETOBSERV-1642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/664): >## Description > >changes to support ovs monitoring config and console bits > >FC config to enable ovs monitoring fearure >```yaml >agent: > type: eBPF > ebpf: > privileged: true > features: > - "OvsMonitor" > >``` >## Dependencies > >https://github.com/netobserv/netobserv-ebpf-agent/pull/286 > >## Checklist > >If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that. > >* [ ] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix _(in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes)._ >* [ ] Does this PR require product documentation? > * [ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs. >* [ ] Does this PR require a product release notes entry? > * [ ] If so, fill in "Release Note Text" in the JIRA. >* [ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc. > * [ ] If so, make sure it is described in the JIRA ticket. >* QE requirements (check 1 from the list): > * [ ] Standard QE validation, with pre-merge tests unless stated otherwise. > * [ ] Regression tests only (e.g. refactoring with no user-facing change). > * [ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team). > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.