search

netobserv / network-observability-operator

An OpenShift / Kubernetes operator for network observability
Apache License 2.0
133 stars 24 forks source link

NETOBSERV-1672: add cluster & zone to predefined metrics (#665) [1.6 backport] #668

Closed jotak closed 1 month ago

jotak commented 1 month ago

cf https://github.com/netobserv/network-observability-operator/pull/665

openshift-ci-robot commented 1 month ago

@jotak: This pull request references NETOBSERV-1672 which is a valid jira issue.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/668): >cf https://github.com/netobserv/network-observability-operator/pull/665 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
memodi commented 1 month ago

/label qe-approved

(based on testing for #665 )

openshift-ci-robot commented 1 month ago

@jotak: This pull request references NETOBSERV-1672 which is a valid jira issue.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/668): >cf https://github.com/netobserv/network-observability-operator/pull/665 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jotak commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/network-observability-operator/blob/release-1.6/OWNERS)~~ [jotak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment