search

netobserv / network-observability-operator

An OpenShift / Kubernetes operator for network observability
Apache License 2.0
133 stars 24 forks source link

NETOBSERV-1647: Do not load loki cert when loki disabled [Backport 1.6] #670

Closed jotak closed 4 weeks ago

jotak commented 1 month ago

cf https://github.com/netobserv/network-observability-operator/pull/669

also includes backport of https://github.com/netobserv/network-observability-operator/pull/662 to fix flaky CI

openshift-ci-robot commented 1 month ago

@jotak: This pull request references NETOBSERV-1647 which is a valid jira issue.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/670): >cf https://github.com/netobserv/network-observability-operator/pull/669 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.59%. Comparing base (df5db3b) to head (d063d25).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.6 #670 +/- ## ============================================ Coverage 66.58% 66.59% ============================================ Files 70 70 Lines 8108 8110 +2 ============================================ + Hits 5399 5401 +2 Misses 2315 2315 Partials 394 394 ``` | [Flag](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/670/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `66.59% <66.66%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/670?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [controllers/consoleplugin/consoleplugin\_objects.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/670?src=pr&el=tree&filepath=controllers%2Fconsoleplugin%2Fconsoleplugin_objects.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-Y29udHJvbGxlcnMvY29uc29sZXBsdWdpbi9jb25zb2xlcGx1Z2luX29iamVjdHMuZ28=) | `87.25% <71.42%> (+0.03%)` | :arrow_up: | | [...trollers/consoleplugin/consoleplugin\_reconciler.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/670?src=pr&el=tree&filepath=controllers%2Fconsoleplugin%2Fconsoleplugin_reconciler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-Y29udHJvbGxlcnMvY29uc29sZXBsdWdpbi9jb25zb2xlcGx1Z2luX3JlY29uY2lsZXIuZ28=) | `71.42% <60.00%> (+0.21%)` | :arrow_up: |
memodi commented 1 month ago

/ok-to-test

github-actions[bot] commented 1 month ago

New images:

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:9f7c731 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-9f7c731

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-9f7c731
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m
memodi commented 1 month ago

this fixes it, thanks!

/label qe-approved

openshift-ci-robot commented 1 month ago

@jotak: This pull request references NETOBSERV-1647 which is a valid jira issue.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/670): >cf https://github.com/netobserv/network-observability-operator/pull/669 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 weeks ago

@jotak: This pull request references NETOBSERV-1647 which is a valid jira issue.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/670): >cf https://github.com/netobserv/network-observability-operator/pull/669 > >also includes backport of https://github.com/netobserv/network-observability-operator/pull/662 to fix flaky CI Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/network-observability-operator/blob/release-1.6/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment