netobserv / network-observability-operator

An OpenShift / Kubernetes operator for network observability
Apache License 2.0
133 stars 24 forks source link

Update documentation from feedback #672

Closed jotak closed 3 weeks ago

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/netobserv/network-observability-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.60%. Comparing base (bc0bcef) to head (864d36b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #672 +/- ## ======================================= Coverage 66.60% 66.60% ======================================= Files 70 70 Lines 8115 8115 ======================================= Hits 5405 5405 Misses 2315 2315 Partials 395 395 ``` | [Flag](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/672/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/672/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `66.60% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/672?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [apis/flowcollector/v1beta2/flowcollector\_types.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/672?src=pr&el=tree&filepath=apis%2Fflowcollector%2Fv1beta2%2Fflowcollector_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93Y29sbGVjdG9yL3YxYmV0YTIvZmxvd2NvbGxlY3Rvcl90eXBlcy5nbw==) | `100.00% <ø> (ø)` | | | [apis/flowmetrics/v1alpha1/flowmetric\_types.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/672?src=pr&el=tree&filepath=apis%2Fflowmetrics%2Fv1alpha1%2Fflowmetric_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93bWV0cmljcy92MWFscGhhMS9mbG93bWV0cmljX3R5cGVzLmdv) | `100.00% <ø> (ø)` | | | [...s/flowcollector/v1beta1/zz\_generated.conversion.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/672?src=pr&el=tree&filepath=apis%2Fflowcollector%2Fv1beta1%2Fzz_generated.conversion.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93Y29sbGVjdG9yL3YxYmV0YTEvenpfZ2VuZXJhdGVkLmNvbnZlcnNpb24uZ28=) | `39.27% <0.00%> (ø)` | | | [...pis/flowcollector/v1beta2/zz\_generated.deepcopy.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/672?src=pr&el=tree&filepath=apis%2Fflowcollector%2Fv1beta2%2Fzz_generated.deepcopy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93Y29sbGVjdG9yL3YxYmV0YTIvenpfZ2VuZXJhdGVkLmRlZXBjb3B5Lmdv) | `43.76% <0.00%> (ø)` | |
jotak commented 3 weeks ago

given that the downstream PR was merged, I'll go ahead and merge this one