search

netobserv / network-observability-operator

An OpenShift / Kubernetes operator for network observability
Apache License 2.0
133 stars 24 forks source link

NETOBSERV-1688: relax ebpf drop alert [1.6 backport] #675

Closed jotak closed 3 weeks ago

jotak commented 3 weeks ago

reformulate some of the text for ebpf drop alert, and relax threshold a little bit.

backport of https://github.com/netobserv/network-observability-operator/pull/674

openshift-ci-robot commented 3 weeks ago

@jotak: This pull request references NETOBSERV-1688 which is a valid jira issue.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/675): >reformulate some of the text for ebpf drop alert, and relax threshold a little bit. > >backport of https://github.com/netobserv/network-observability-operator/pull/674 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.77%. Comparing base (8c0c1eb) to head (bd29816).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.6 #675 +/- ## =============================================== + Coverage 66.59% 66.77% +0.18% =============================================== Files 70 69 -1 Lines 8110 8088 -22 =============================================== Hits 5401 5401 + Misses 2315 2293 -22 Partials 394 394 ``` | [Flag](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/675/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | `66.77% <100.00%> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/675?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv) | Coverage Δ | | |---|---|---| | [apis/flowcollector/v1beta1/flowcollector\_types.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/675?src=pr&el=tree&filepath=apis%2Fflowcollector%2Fv1beta1%2Fflowcollector_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93Y29sbGVjdG9yL3YxYmV0YTEvZmxvd2NvbGxlY3Rvcl90eXBlcy5nbw==) | `100.00% <ø> (ø)` | | | [apis/flowcollector/v1beta2/flowcollector\_types.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/675?src=pr&el=tree&filepath=apis%2Fflowcollector%2Fv1beta2%2Fflowcollector_types.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-YXBpcy9mbG93Y29sbGVjdG9yL3YxYmV0YTIvZmxvd2NvbGxlY3Rvcl90eXBlcy5nbw==) | `100.00% <ø> (ø)` | | | [controllers/ebpf/agent\_controller.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/675?src=pr&el=tree&filepath=controllers%2Febpf%2Fagent_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-Y29udHJvbGxlcnMvZWJwZi9hZ2VudF9jb250cm9sbGVyLmdv) | `59.64% <ø> (ø)` | | | [controllers/ebpf/agent\_metrics.go](https://app.codecov.io/gh/netobserv/network-observability-operator/pull/675?src=pr&el=tree&filepath=controllers%2Febpf%2Fagent_metrics.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=netobserv#diff-Y29udHJvbGxlcnMvZWJwZi9hZ2VudF9tZXRyaWNzLmdv) | `89.56% <100.00%> (ø)` | |
memodi commented 3 weeks ago

/ok-to-test

github-actions[bot] commented 3 weeks ago

New images:

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:87c7863 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-87c7863

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-87c7863
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m
memodi commented 3 weeks ago

/label qe-approved

openshift-ci-robot commented 3 weeks ago

@jotak: This pull request references NETOBSERV-1688 which is a valid jira issue.

In response to [this](https://github.com/netobserv/network-observability-operator/pull/675): >reformulate some of the text for ebpf drop alert, and relax threshold a little bit. > >backport of https://github.com/netobserv/network-observability-operator/pull/674 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=netobserv%2Fnetwork-observability-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jotak commented 3 weeks ago

/approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/netobserv/network-observability-operator/blob/release-1.6/OWNERS)~~ [jotak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment