Closed thiagogomesverissimo closed 6 years ago
@thiagogomesverissimo, thanks for your contribution, I will analyze and approve the pr.
Nice. :cat:
I am creating issues to fix the remaining things
@thiagogomesverissimo, Thanks, can you give me some contact from you? email or slack? Let's have a chat to continue this project.
First, congratulations, the project is so great.
I read the discussion on https://github.com/NetoDevel/cli-spring-boot-scaffold/pull/44 about code generator in spring 2. Given your necessity to keep retro compatibility with spring 1, I did some work on it and tried to change the minimal. I hope you appreciate it.
To achieve that, and as you suggested, now scaffold.info have a variable called springVersion that can be 1.x or 2.x, and the generator handle the correct method findOne or findById accordingly
In version 2.x, I did not investigated yet, but the bootstrap cdn is not being load. But I will leave this to another issue/PR
I am sending a minimal .gitignore
I dit not generate a new sample project, because we can discuss before how organize the samples. Something like: sample/1.x, sample/2.x. This can be another issue/PR
I do not change the spring version of your project. It is still 1.4.2.RELEASE, but now it generates code to version 2.x of spring
I do not change artifact version, it is still 0.0.1.BUILD-SNAPSHOT.
Default scaffold is to spring 1.x
That is it! The generator now works with spring 1 and spring 2 by change scaffold.info