Improve right prompt - Githubissues

netologist / theme-lambda

lambda theme for oh my fish

MIT License

64 stars 43 forks source link

Improve right prompt #8

Closed phra closed 5 years ago

phra commented 6 years ago

i made some small improvements to the right prompt of lambda theme and i would like to merge them to the main repository.

print green exit status if 0
print and format $CMD_DURATION

fixes #9

phra commented 6 years ago

@hasanozgan any update?

js402882 commented 6 years ago

I have visually more subtle and much simpler implementation for $CMD_DURATION display (basically no more than 1 one-liner). If there would be response and interest from @hasanozgan I can prepare merge request for it.

phra commented 6 years ago

@js402882 i can give you access to my fork to update this PR if you want.

phra commented 5 years ago

@hasanozgan @js402882 is anyone alive guys?

faogustavo commented 4 years ago

@phra @hasanozgan I'm facing some problems with these changes. After taking a look at the code I discovered that the problem is in the line 16. The math done in this line, shows me an error message like this:

0.000001: value not completely converted

After commenting this line, everything works properly.

My setup is:

OS: Linux (Debian 10 - but had the same problem on ubuntu 19.04 and 19.10)
KDE IDE
Using Hyper or Konsole

alonsodomin commented 4 years ago

Same happens in MacOS, there is a fix in #12.

To be honest, this should have never been merged, there is little value in the additional $CMD_DURATION info in the prompt and because of poor testing, it broke a perfectly working prompt.