netpicker / netpicker

Test your network compliance, design and security. Python based unit testing against all your network configs, data and real-time show commands
https://netpicker.io
14 stars 2 forks source link

mikrotik_routeros platform using incorrect command for config backup #4

Closed gorbyhail closed 3 months ago

gorbyhail commented 3 months ago

Hey, another issue but hopefully this one is simple :)

The mikrotik_routeros platform appears to be trying to use the command "show", which doesn't actually exist on routeros, for a config backup.

The "export" command is probably a better bet as this outputs the entire config with nothing hidden.

image

gorbyhail commented 3 months ago

Used your guide here to change the config backup command: https://netpicker.io/knowledge-base/custom-config-backup-command-setup/ and it is now working perfectly! Apologies for opening an issue before thoroughly checking your knowledgebase

CopyBook-Maxim commented 1 month ago

Used your guide here to change the config backup command: https://netpicker.io/knowledge-base/custom-config-backup-command-setup/ and it is now working perfectly! Apologies for opening an issue before thoroughly checking your knowledgebase

Hello

I too have encountered this problem. But as per the given link, this solution is not working for me.

I have added environment variables for agent container in docker-compose.yml. I also see in the inside of the container itself that this setting has appeared.

But when collecting backups, I still get “bad command name show (line 1 column 1)”.

Could you please show me the configuration of your docker-compose.yml file for this case?

Thanks!

Translated with DeepL.com (free version)

ottocoster commented 1 month ago

Which vendor and which config backup command are you using?

The {vendor} part in the SHENV_SHOW_RUN_{vendor} environment variable should match with the platform of the device in Netpicker.

CopyBook-Maxim commented 1 month ago

Which vendor and which config backup command are you using?

The {vendor} part in the SHENV_SHOW_RUN_{vendor} environment variable should match with the platform of the device in Netpicker.

  agent:
    hostname: agent
    image: netpicker/agent:latest
    container_name: agent
    labels:
      service.netpicker.io: agent
    environment:
      CLI_PROXY_ADDR: '0.0.0.0'
      SHENV_SHOW_RUN_nokia_srl: 'info'
      SHENV_PRIVILEGED_PLATFORMS: 'privileged_platform'
      SHENV_SHOW_RUN_mikrotik_routeros: 'export'

Vendor - Mikrotik, platform - router. I add env match with the platform of the device in Netpicker

CopyBook-Maxim commented 1 month ago

Hi I managed to build a configuration with Mikrotik But for that I had to create a rule for mikrotik_routeros, same as Juniper Command backup (display set).

In this case in the Command backup tab the configuration is built and appears. But this is not the result I wanted.

I have tried many times in docker-compose.yml to add the SHENV_SHOW_RUN_mikrotik_routeros: 'export' clause, tried to find this env in the container itself, but all to no avail.

ottocoster commented 1 month ago

I can reproduce it with our Mikrotik. Wil be fixed in the coming release.

ottocoster commented 1 month ago

Okay, I found the issue. The SHENV_SHOW_RUN_{vendor} environment variables need to be put inside the kibbitzer container instead of the agent container. Then it should work.

I've updated our documentation here: https://netpicker.io/knowledge-base/custom-config-backup-command-setup/

CopyBook-Maxim commented 1 month ago

Okay, I found the issue. The SHENV_SHOW_RUN_{vendor} environment variables need to be put inside the kibbitzer container instead of the agent container. Then it should work.

I've updated our documentation here: https://netpicker.io/knowledge-base/custom-config-backup-command-setup/

Yes!

It really works.

Thank you very much!