Unpack dependencies is failing: Negative time

[adioss]

Hi,

The source jar that contains the sources from the last version 2.5.0:

• https://repo1.maven.org/maven2/net/minidev/json-smart/2.5.0/json-smart-2.5.0-sources.jar
• All the files have a modified date which is ‎31 ‎December ‎1969, ‏‎23:00:10
• so: it cannot be unpacked by org.codehaus.plexus.archiver.AbstractUnArchiver (java.lang.IllegalArgumentException: Negative time standard component like maven-dependency-plugin used to unpack dependencies will fail

Reprocase:

• create a mvn project from scratch
• add the dependency

      <dependency>
          <groupId>net.minidev</groupId>
          <artifactId>json-smart</artifactId>
          <version>2.5.0</version>
      </dependency>

• extract dependencies using this command:

  
  mvn package org.apache.maven.plugins:maven-dependency-plugin:3.6.1:unpack-dependencies -X -Dclassifier=sources -DincludeScope=compile -DoutputDirectory="./target/dependency-sources" -DskipTests=true --batch-mode
  (...)
  [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:unpack-dependencies (default-cli) on project mvnExtractDependencies: Execution default-cli of goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:unpack-dependencies failed: Negative time -> [Help 1]
  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:unpack-dependencies (default-cli) on project mvnExtractDependencies: Execution default-cli of goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:unpack-dependencies failed: Negative time
  at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:375)
  at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
  at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
  at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
  at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
  at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298)
  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
  at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke (Method.java:498)
  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
  at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
  Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-cli of goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:unpack-dependencies failed: Negative time
  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:148)
  at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
  at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
  at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
  at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
  at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
  at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298)
  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
  at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke (Method.java:498)
  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
  at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
  Caused by: java.lang.IllegalArgumentException: Negative time
  at java.io.File.setLastModified (File.java:1466)
  at org.codehaus.plexus.archiver.AbstractUnArchiver.extractFile (AbstractUnArchiver.java:328)
  at org.codehaus.plexus.archiver.zip.AbstractZipUnArchiver.execute (AbstractZipUnArchiver.java:172)
  at org.codehaus.plexus.archiver.zip.AbstractZipUnArchiver.execute (AbstractZipUnArchiver.java:143)
  at org.codehaus.plexus.archiver.AbstractUnArchiver.extract (AbstractUnArchiver.java:142)
  at org.apache.maven.plugins.dependency.utils.UnpackUtil.unpack (UnpackUtil.java:149)
  at org.apache.maven.plugins.dependency.fromDependencies.UnpackDependenciesMojo.doExecute (UnpackDependenciesMojo.java:121)
  at org.apache.maven.plugins.dependency.AbstractDependencyMojo.execute (AbstractDependencyMojo.java:125)
  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
  at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
  at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
  at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
  at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
  at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
  at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
  at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
  at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:298)
  at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
  at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
  at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
  at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
  at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
  at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke (Method.java:498)
  at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
  at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
  at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
  at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
  [ERROR]
  [ERROR]
  [ERROR] For more information about the errors and possible solutions, please read the following articles:
  [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException

Notes: 
* Reproduced on Windows/Linux
* 2.4.9: Modified was empty
* 2.4.8: Modified was ok (a date > epoch)

Adrien

[shoothzj]

I've successfully replicated this issue on my laptop. It seems to be associated with the 10</project.build.outputTimestamp> setting. I'll need some additional time to investigate this matter thoroughly.