search

netpyoung / unity.libsodium

🔑 libsodium made easy for Unity3d
MIT License
17 stars 4 forks source link

apply pull request #3

Closed netpyoung closed 6 years ago

netpyoung commented 6 years ago

https://github.com/netpyoung/unity.libsodium/pull/2

TODO

Ekwav commented 6 years ago

About the autogen.cs, maybe scrap the current docs from https://download.libsodium.org/doc/ then select all functions with this regex: `\Rint (.|\R)?);\R, select the parameters types and replace them with the equivalent in c#, write the result into theNativeLibsodium` class. Not sure how future proof this would be.

netpyoung commented 6 years ago

yes. I also not sure which way is good or not. so I just postpone.

they also hardcoding that https://github.com/adamcaudill/libsodium-net/blob/master/libsodium-net/Interop/SodiumLibrary.cs

Ekwav commented 6 years ago

Indeed, they are also missing the latest APIs for Sodium 1.0.16 But I think there will be less and less new functions because as the roadmap says

New features will be gladly implemented provided that they are not redundant and solve common problems.

New functions are most likely redundant of existing ones. So maybe it is even overkill to take the time and make a autogen.cs

netpyoung commented 6 years ago

yes. It is better to add manually now. and I already applied your pull request. Okay I will close this issue.