search

netpyoung / unity.webp

:art: WebP made easy for Unity3d
https://netpyoung.github.io/unity.webp/
MIT License
237 stars 28 forks source link

Change autoReferenced from false to true at WebP.asmdef #40

Closed tk-aria closed 2 years ago

tk-aria commented 2 years ago

Thanks for the great features, but there's one problem.

why disable autoReferenced ? usualy enable autoReferenced at runtime module, because many projects doesn't apply asmdef to application features.

on the other hand, it is possible to incorporate functions into AssemblyCSharp by creating a reference asmdef and writing a wrapper, but this increases the introduction cost.

So, I think it's better to set autoReferenced to true.

netpyoung commented 2 years ago

Yes your point of view also reasonable. Some projects want to reference explicit instead of implicit. still now I didn't know which way is good way to go ahead. But in this case, because I had tried unchecked autoreference from https://github.com/netpyoung/unity.webp/pull/30#issuecomment-938687519, so I will retry autoreference version again.