feat: Add concrete types ParseHookTrigger and ParseHookFunction

netreconlab / Parse-Swift

The original (OG) Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, visionOS, Linux, Android, Windows). This repo is maintained by Parse-Swift's original developer and all new features and bug fixes will occur here.

Apache License 2.0

59 stars 6 forks source link

New Pull Request Checklist

[x] I am not disclosing a vulnerability.
[x] I am creating this PR in reference to an issue.

Issue Description

Developers currently need to create unnecessary types for ParseHookTrigger and ParseHookFunction that conform to respective protocols
There is a problem when the developer did not implement merge() on a ParseObject and depended on the internal mergeAutomatically() to merge. If the developer used mergeAutomatically() indirectly for objects with different objectId's, the method allowed the merge. Now the method now throws the proper error

Approach

[x] Provide concrete types: ParseHookTrigger and ParseHookFunction to reduce code developers need to write
[x] Deprecate triggerName in favor of trigger where applicable
[x] The SDK also yields for 0.5 second as oppose to 1 second, which can lead to faster app starts
[x] Increase overall codecov

TODOs before merging

[x] Add tests
[x] Add entry to changelog
[x] Add changes to documentation (guides, repository pages, in-code descriptions)

Codecov Report

Merging #122 (afb0b41) into main (835083e) will increase coverage by 0.14%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   91.58%   91.72%   +0.14%     
==========================================
  Files         173      175       +2     
  Lines       15424    15457      +33     
==========================================
+ Hits        14126    14178      +52     
+ Misses       1298     1279      -19

Impacted Files	Coverage Δ
Sources/ParseSwift/API/API.swift	`100.00% <100.00%> (+0.58%)`	:arrow_up:
Sources/ParseSwift/Objects/ParseObject.swift	`91.26% <100.00%> (+0.31%)`	:arrow_up:
Sources/ParseSwift/Objects/ParseRole.swift	`100.00% <100.00%> (+12.00%)`	:arrow_up:
Sources/ParseSwift/Parse.swift	`99.06% <100.00%> (+1.86%)`	:arrow_up:
...s/ParseSwift/Protocols/ParseHookFunctionable.swift	`100.00% <100.00%> (ø)`
...es/ParseSwift/Protocols/ParseHookTriggerable.swift	`100.00% <100.00%> (ø)`
Sources/ParseSwift/Types/ParseHookFunction.swift	`100.00% <100.00%> (ø)`
Sources/ParseSwift/Types/ParseHookTrigger.swift	`100.00% <100.00%> (ø)`
...rseSwift/Types/ParseHookTriggerObjectRequest.swift	`100.00% <100.00%> (ø)`
...ces/ParseSwift/Types/ParseHookTriggerRequest.swift	`94.11% <100.00%> (+1.26%)`	:arrow_up:
... and 2 more

... and 1 file with indirect coverage changes