netreconlab / Parse-Swift

The original (OG) Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, visionOS, Linux, Android, Windows). This repo is maintained by Parse-Swift's original developer and all new features and bug fixes will occur here.
https://swiftpackageindex.com/netreconlab/Parse-Swift/documentation
Apache License 2.0
62 stars 7 forks source link

feat: Add missing become() type methods #66

Closed cbaker6 closed 1 year ago

cbaker6 commented 1 year ago

New Pull Request Checklist

Issue Description

The become() type method is currently not available to use for async/await and Combine.

Approach

Add the missing methods and have them call their completion handler counterpart.

TODOs before merging

codecov[bot] commented 1 year ago

Codecov Report

Merging #66 (f5b8650) into main (ed55608) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   90.45%   90.46%           
=======================================
  Files         166      166           
  Lines       14942    14952   +10     
=======================================
+ Hits        13516    13526   +10     
  Misses       1426     1426           
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseUser+async.swift 94.23% <100.00%> (+0.12%) :arrow_up:
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.86% <100.00%> (+0.14%) :arrow_up:

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.