search

netresearch / dhl-module-shipping-m2

This extension is in legacy status since 04/2020 and will run out of maintenance and support after a short transition period. You can find the official replacement extension here https://github.com/netresearch/dhl-shipping-m2. It includes the latest and greatest possible range of functions that DHL is currently offering.
30 stars 21 forks source link

lbs instead of Kg #33

Closed MarcusWolschon closed 5 years ago

MarcusWolschon commented 5 years ago

Bug description For english orders, the product weight is used in "lbs" in the DHLShipping-M2 dialog.

Steps to reproduce To reproduce the problem: 1.Set up Magento 2.2.6 with dhl-module-shipping-m2 0.9.0 2.Set Stores->Configuration->General->General->Locale Options->Weight Unit to "kgs" for Default, Website and all Views of that webside

  1. Select frontend and admin-frontend to be English
  2. place an order
  3. try to buy postage for that order
  4. The weight is the correct number for Kilogramm but the unit is "lbs"

Expected behavior The weight of the combined products (+packaging) should be displayed and the selected unit is "kgs".

Screenshots / logs (sorry, can't publicly post screenshots that inevitably contain customer data.)

Environment

FAQ Has the Knowledge Base been checked for a solution?

simonmaass commented 5 years ago

Same issue with same setup

ngolatka commented 5 years ago

We actually thought that this was fixed in version 0.9.0, but I can duplicate the problem. Will check what happened here.

However, the module should still transmit the correct value (in kg) to DHL, and that should also show up on the label. Can you guys confirm that, @MarcusWolschon @simonmaass ?

MarcusWolschon commented 5 years ago

No, instead of 1Kg a shipping label for 0.454 kg = 1lbs was created.

ngolatka commented 5 years ago

Thanks for checking @MarcusWolschon. We'll take a look at it.

ngolatka commented 5 years ago

Confirmed: the issue was indeed resolved, but the commit got mangled later on.

This will be fixed in future versions.

powli commented 5 years ago

@MarcusWolschon @simonmaass fixed with 0.9.1