search

netresearch / dhl-module-ui

Module for providing the presentation layer within the Magento application for custom functionality
Open Software License 3.0
3 stars 0 forks source link

Null street at checkout #5

Closed okolya closed 3 years ago

okolya commented 3 years ago

https://github.com/netresearch/dhl-module-ui/blob/8454c34b969c1880790db8ee0dc71857c82d7358/view/frontend/web/js/view/input/shopfinder.js#L77

When new session without addess is activated at checkout page then this line produces error.

And shopfinder button is not available. Screenshot_at_15-10-35

okolya commented 3 years ago

Solution: replace with line

this.searchStreet(address.street ? address.street.join(' ') : '');
mam08ixo commented 3 years ago

Thank you! The issue has a fix that is waiting for a release. It did not make it into the upcoming 1.5.0 though. I will keep this issue open until the fix was released.

okolya commented 3 years ago

Do you mean the release of dhl/module-ui or dhl/shipping-m2 ? I am wondering because the dhl/shipping-m2 moduel has already 1.5.0 version. And the dhl/module-ui module has only 1.2.2 .

mam08ixo commented 3 years ago

Sorry for the confusion. I was referring to the metapackage dhl/shipping-m2 which is indeed already available in version 1.5.0 on GitHub but not yet on Magento Marketplace.

okolya commented 3 years ago

Am I right, that you are going to release dhl/module-ui 1.2.3 and update dhl/shipping-m2 ? The reported issue has occured by dhl/shipping-m2 wich was installed from github (1.5.0).

Screenshot_at_17-19-18

I have found how to apply fix inside my template. But it overwrites complete shopfinder.js component. Unfortunately there is no way how to do it with mixin logic.

Are you planning to apply fix to resolve this issue?

mam08ixo commented 3 years ago

The fix will be included with the next dhl/module-ui version as part of the next metapackage release.

mam08ixo commented 3 years ago

Fixed in version 1.2.3