netresearch / dhl-module-ui

Module for providing the presentation layer within the Magento application for custom functionality
Open Software License 3.0
3 stars 0 forks source link

Wrong language in Checkout-data API Call #9

Closed template-provider closed 3 years ago

template-provider commented 3 years ago

We experienced a problem with the language in our shop. Sometimes the language of the dhl shipping is german, sometimes english.

Bildschirmfoto vom 2021-01-08 19-50-26

I debugged the problem and I think there is a caching (id) problem with the /de/rest/de/V1/dhl/checkout-data/get API call. The Dhl\ShippingCore\Model\ShippingSettings\Config\Reader in Line 93 uses for caching id a config id and the scope (like "frontend"). However, the store id is not part of the caching id. The result:

mam08ixo commented 3 years ago

Yes, your observation is correct. We are aware of this (and some other edge cases related to local storage). The reason why this is not considered high priority yet is that a user is unlikely to switch language after they enter checkout, so the service box language should in most of all cases be correct. There is no ETA yet for a fix.

mam08ixo commented 3 years ago

Behavior was changed in version 1.2.3