netresearch / dhl-shipping-m2

DHL multi-division shipping extension for Magento 2
Open Software License 3.0
13 stars 4 forks source link

No decimal point allowed for width + length of own package #29

Closed YiffyToys closed 3 years ago

YiffyToys commented 3 years ago

grafik

Height can contain a comma but width can not (Above it says "Module version: 1.1.5")

ngolatka commented 3 years ago

Confirmed in version 1.5.1. Strangely, length and width have the class validate-digits but height has validate-number.

Thanks for reporting this. We'll check it.

Sidenote: In the shipping popup (manual label creation) you can enter decimal values for width, height, and length, but only integers will be sent in the API request anyway:

<ShipmentItem><weightInKG>2.6</weightInKG><lengthInCM>10</lengthInCM><widthInCM>15</widthInCM><heightInCM>20</heightInCM></ShipmentItem>

The values will be cast to integer by our module before sending them to the API.

(internal ref: DHLGW-1100)

ngolatka commented 3 years ago

Above it says "Module version: 1.1.5"

Short explanation about that apparent mismatch (1.1.5 vs. 1.5.1): in the UI, you see the versions of various sub-modules/packages. The meta-package's version is visible in your composer.lock. Look for "name": "dhl/shipping-m2" and you'll see it. That version is usually more helpful during support requests.

To see the versions of all DHL packages superfast, do this: grep --after-context=1 "\"name\": \"dhl/" composer.lock

ngolatka commented 3 years ago

Will be fixed in the next version 2.0.0 (no ETA yet).

Because we want uniform input fields everywhere, regardless of the API, we'll allow decimal values even if the German DHL Paket API doesn't handle those. The values will be rounded (not cast to int anymore) in our module before being sent to the API.

mam08ixo commented 3 years ago

DHL Shipping version 2.0.0 now allows all dimensions to be entered as decimal values. However, due to the requirements of the DHL Paket API, they will be rounded to integer when requesting a shipping label.