netresearch / dhl-shipping-m2

DHL multi-division shipping extension for Magento 2
Open Software License 3.0
13 stars 4 forks source link

Weird CSS errors #50

Closed OvalMedia closed 1 year ago

OvalMedia commented 1 year ago

I am maintaining 2 separate magentos (both 2.4.4). Both have the dhl/shipping-m2 module (2.7.0) installed.

In one of those shops the admin part looks somewhat broken as if some css is missing: dhl-1

While in the other this looks fine: dhl-2

How can I fix this?

In addition to that there is an issue with the display of dropdowns in BOTH shops: dhl-3

The dropdowns and text fields are all collapsed. This can be fixed by adding these classes to the form fields:

Maybe there are more of these classes. I haven't dug too deep but I have a feeling this is something new in 2.4.4. I had the same issue with another module after upgrading to 2.4.4.

mam08ixo commented 1 year ago

Please run composer info -l netresearch* and compare the result.

For us to be able to reproduce the issue, please add more detail about how you process CSS/LESS in your environments.

OvalMedia commented 1 year ago
netresearch/config-fields-m2                    1.3.0  1.3.0
netresearch/jsonmapper                          v4.0.0 v4.0.0
netresearch/module-admin-notification-feed      1.0.0  1.0.0
netresearch/module-interactive-batch-processing 1.1.0  1.1.0
netresearch/module-shipping-core                2.8.2  2.8.2
netresearch/module-shipping-ui                  2.3.2  2.3.2

For the frontend I am using gulp and sass but I assume that is unrelated. Regarding less: to be honest, I have no idea. I never used less explicilty and as far as I know I never needed it.

For deployment I am using this script in all my magento 2 projects:

#!/bin/bash

cd /web/;

MAG=bin/magento
OPT=" -d memory_limit=-1 "

if [ ! -f $MAG ]; then
        echo "Magento instance not found!";
        exit;
fi

php $OPT $MAG deploy:mode:show;
php $OPT $MAG maintenance:enable;

rm -rf pub/static/frontend/
rm -rf pub/static/adminhtml/
rm -rf var/view_preprocessed/*
rm -rf generated/code/*
rm -rf generated/metadata/*

php $OPT $MAG cache:flush 2>&1;
php $OPT $MAG setup:upgrade 2>&1;
php $OPT $MAG setup:di:compile 2>&1;

php $OPT $MAG setup:static-content:deploy en_US de_DE --exclude-theme Magento/luma --exclude-theme Magento/blank -f;

php $OPT $MAG cache:clean 2>&1;
php $OPT $MAG index:reindex 2>&1;

php $OPT $MAG maintenance:disable;
mam08ixo commented 1 year ago

Okay that does not look any special to me. Thing is, we have no such complaints from other merchants on our support channels and cannot replicate the issue in any of our environments. Neither does it occur consistently in yours.

We can certainly align our class attributes with the Magento core config field elements, but from there you are on your own I am afraid.

OvalMedia commented 1 year ago

Ok, thank you. The module itself seems to work fine. But the collapsed fields need a fix though.