search

netresearch / t3x-rte_ckeditor_image

Image support in CKEditor for the TYPO3 ecosystem
GNU Affero General Public License v3.0
56 stars 65 forks source link

[bugfix/145]Fix disabled button. #149

Closed lucmuller closed 2 years ago

lucmuller commented 2 years ago

Solution is parsing of every toolbars, then checking if the command is 'image'. If yes, put the button state at 'off' since button.getState returns undefined

lucmuller commented 2 years ago

Don't know why, but I had the ability to create 2 PR with my commit ?

Not so much used to git pull request process. I din't find a way to contribute directly to the 10.2.0 tag had to commit to V10 branch. But seems leggit.

CybotTM commented 2 years ago

Hi @lucmuller,

Don't know why, but I had the ability to create 2 PR with my commit ?

Yes, of course, you can create as many PR as you like from a single commit.

I din't find a way to contribute directly to the 10.2.0 tag had to commit to V10 branch. But seems leggit.

That's correct, you cannot create PR with a tag (single commit) as target. You can only create a PR with a branch as target - which is usually master/main. But in our case it is TYPO3_10.

CybotTM commented 2 years ago

Thank you, merged and released: https://github.com/netresearch/t3x-rte_ckeditor_image/releases/tag/v10.2.1