search

netresearch / t3x-rte_ckeditor_image

Image support in CKEditor for the TYPO3 ecosystem
GNU Affero General Public License v3.0
56 stars 65 forks source link

[BUGFIX] generate publicUrl from originalImageFile storage #219

Closed lukasniestroj closed 1 year ago

magicsunday commented 1 year ago

Hello Lukas,

thanks for your pull request. Can you please explain to me what the change does (doesn't seem to exists to much documentation about FileProcessingAspect). Is this simply the new equivalent for the rather old code? Wouldn't it then be required, to add the:

GeneralUtility::makeInstance(Context::class)->setAspect('fileProcessing', new FileProcessingAspect(false));

also to the other places that have a createMagicImage() call?

lukasniestroj commented 1 year ago

I will try to provide more Infos on that.

Rico Sonntag @.***> schrieb am Fr., 10. Feb. 2023, 12:36:

Hello Lukas,

thanks for your pull request. Can you please explain to me what the change does (doesn't seem to exists to much documentation about FileProcessingAspect). Is this simply the new equivalent for the rather old code? Wouldn't it then be required, to add the:

GeneralUtility::makeInstance(Context::class)->setAspect('fileProcessing', new FileProcessingAspect(false));

also to the other places that have a createMagicImage() call?

— Reply to this email directly, view it on GitHub https://github.com/netresearch/t3x-rte_ckeditor_image/pull/219#issuecomment-1425677084, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF7RD32BVGZYP44XZFCAZGDWWYR4VANCNFSM6AAAAAAUUBBODY . You are receiving this because you authored the thread.Message ID: @.***>