search

netresearch / t3x-rte_ckeditor_image

Image support in CKEditor for the TYPO3 ecosystem
GNU Affero General Public License v3.0
56 stars 65 forks source link

Rte image preview broken since v11.0.12 #251

Closed Patta closed 1 year ago

Patta commented 1 year ago

Bug description Since v11.0.12 the backend rte image preview is not working anymore. The preview only shows just html/code of the image.

Steps to reproduce To reproduce the problem:

  1. Setup
  2. Add image to rte
  3. Look at page with web module

Expected behavior Preview of rte image

Screenshots or logs

Should: image

Is: image

Workaround: revert commit https://github.com/netresearch/t3x-rte_ckeditor_image/commit/9fb0b0e68c825c1d480da194b8b86300ac8dac79

Environment

Documentation Have you checked the readme/documentation?

Patta commented 1 year ago

Additional, the commit https://github.com/netresearch/t3x-rte_ckeditor_image/commit/9fb0b0e68c825c1d480da194b8b86300ac8dac79 breaks all other content element previews.

Is: Text element is with v11.0.12: image

Should: Text element with v11.0.11: image

magicsunday commented 1 year ago

Hi, could you please check if branch https://github.com/netresearch/t3x-rte_ckeditor_image/tree/GH-244 fixes your problems?

Patta commented 1 year ago

@magicsunday the changes in https://github.com/netresearch/t3x-rte_ckeditor_image/commit/908d149cdf89601743215a39f365367eca48d0ff fixes this issues, yes. Maybe you could use the https://github.com/TYPO3/html-sanitizer for that.

magicsunday commented 1 year ago

New release 11.0.13 created.